loading.js uses canvas-based animations and sketch instances have their own indicator - #9119
Open
Jextic wants to merge 2 commits into
Open
loading.js uses canvas-based animations and sketch instances have their own indicator#9119Jextic wants to merge 2 commits into
Jextic wants to merge 2 commits into
Conversation
…have its own loading indicator centered on the canvas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8922
Changes:
_createLoadingIndicator()to_createLoadingOverlay._createLoadingOverlaycreates another canvas (which will contain the loading indicator) right on top of the user's canvas (or default canvas)._positionCanvas(),_removeLoadingOverlay(), anddrawLoadingIndicator()were added to help center the loading indicator, remove it when it's no longer loading, and use draw the p5 logo using canvas functions._handleLoadingIndicator()to intercept the canvas whenever canvas-related functions (createCanvas,resizeCanvas, andnoCanvas) are called on.Screenshots of the change:
Video of instance mode sketches:
instance-mode-loading.mp4
This uses the instance mode sketch provided in the issue comment thread plus a modified version of the issue's first sketch example to show that the loading indicator will resize itself respectively to when the canvas resizes.
PR Checklist
npm run lintpasses