Add typography performance tests#8918
Conversation
ksen0
left a comment
There was a problem hiding this comment.
Thanks for the work here! Comments below based on going through this PR with @limzykenneth .
The priority, especially if full completion is out of rant scope, is to complete the harness. If not possible to complete all the functions, these can be left open to community implementation in a new issue.
If possible, in addition to the minimal performance testing doc, it would be great to add instructions + example code for running manually (via CLI not the editor) a comparison between v1 and v2. As discussed, there is no equivalent quite for v1, but enabling comparison between v1 and v2 (even if manual / documentation primarily) would be ideall
|
|
||
| Implementation notes: | ||
|
|
||
| - All pre-existing benchmarks included the full p5 instance setup which adds ~50ms to each test. The `textToPoints() single word, isolated benchmark` test is included as a potential way to isolate performance testing away from setup overhead. |
There was a problem hiding this comment.
Same here: con be added to a new contributor doc on performance testing. That can be very short, so not necessary to add more than what you have here.
931e807 to
1a4fb64
Compare
1a4fb64 to
57e23f3
Compare
Continuous ReleaseCDN linkPublished PackagesCommit hash: 57e23f3 Previous deploymentsThis is an automated message. |
|
Thanks for the work here @shakeelmohamed ! I'm experiencing some flakiness, any ideas? If it's just a me problem / usage, totally ok, but I'm using the command from the docs so if there's other steps please do add those. Alternatively if this is a problem, do you have capacity to resolve it? (I did Run 1 BENCH Summary
unit-tests (chrome) textToPoints() single word - test/bench/typography.bench.js:49:1 > Typography: bench 2D
1.54x faster than textToPoints() single word, with render
2.63x faster than textToPoints() single word, 150pt
3.91x faster than textToPoints() 10 words
58.40x faster than textToPoints() paragraph
unit-tests (chrome) textToPoints() single word - test/bench/typography.bench.js:75:1 > Typography: bench WebGL
2.99x faster than textToPoints() single word, 150pt
4.58x faster than textToPoints() 10 words
17.74x faster than textToPoints() single word, with render
67.00x faster than textToPoints() paragraph
unit-tests (chrome) textToPoints() single word - test/bench/typography.bench.js:101:1 > Typography: bench WebGPU
2.84x faster than textToPoints() single word, with render
4.93x faster than textToPoints() single word, 150pt
7.65x faster than textToPoints() 10 words
82.36x faster than textToPoints() paragraph
unit-tests-webgpu (chrome) textToPoints() single word - test/bench/typography.bench.js:49:1 > Typography: bench 2D
NaNx faster than textToPoints() single word, 150pt
NaNx faster than textToPoints() single word, with render
NaNx faster than textToPoints() 10 words
NaNx faster than textToPoints() paragraph
Run 2Run 3Error outputand one of the times it was that one but on webgpu |
Add initial performance benchmark tests and structure for typography tests.
PR Checklist
npm run lintpasses