Repository navigation
fix: do not insert an extra <?php before a comment after a control structure - #2547
Open
Dextheking1 wants to merge 1 commit into
Open
Dextheking1 wants to merge 1 commit into
Dextheking1 wants to merge 1 commit into
Conversation
Dextheking1
marked this pull request as ready for review
October 23, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2494
Input:
Output before:
The comment attaches as a leading comment of the inline node in the if body.
printLinesprinted an opening<?phpfor it, but a block body is already inside an open php region, so the output is a syntax error. The same bug hit while/foreach in alternative syntax and the brace form.The opening
<?phpis now only printed when the parent is the program itself, the one case where no tag is open yet. Program-level output is unchanged.New fixtures in tests/inline-comment-after-if cover if, while and the brace form. Full suite passes (104 suites, 602 tests), no snapshot changes elsewhere. AST_COMPARE=1 passes on the new fixtures.