Recreate uid.js build artifact#6
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc157ea198
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| commons.ajax(ENDPOINT, saveData, null, { | ||
| withCredentials: true | ||
| }); |
There was a problem hiding this comment.
When the cache is missing or expired, getBuyerUids reaches this call with the user's callback, but commons.ajax treats a function callback as success-only and uses its default error handler that only logs. In any /getuids HTTP failure, network error, or timeout, the public window.pbs.getBuyerUids(callback) never invokes callback(error, null), so consumers waiting for either result can hang indefinitely instead of handling the failure.
Useful? React with 👍 / 👎.
1 participant
Fixes #4