Repository navigation
fix(web): bound Bulk results for tenant 10 migration - #271
Merged
Merged
Conversation
Unintended layout regression: long Azure resource URLs expanded fractional grid tracks at 900 px. Inspected the failed and corrected screenshots; bound text tracks and reuse copy/truncate fields without rewriting visual baselines. Unit RED/GREEN, five built-frontend browser flows, strict added-spec types, production build, coverage and size budgets pass. Full TypeScript diagnostics remain at the verified HEAD baseline. Preserve 0.55.67 migration-only performance exception; customer production is excluded. Corrected immutable-image publication and complete actual target acceptance remain pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Only loopback frontend evidence is available; corrected-image dev/canary browser acceptance and explicit operator visual confirmation still require human follow-through.
No open issues 🎉
What changed in this PR
This frontend-only repair addresses Bulk result overflow found during tenant 10 migration acceptance. It bounds long values using existing UI primitives without changing API behavior, dependencies, or visual baselines.
Changes:
- Bound flexible result-grid columns and add truncation with full-value copying for identifiers, locations, and error details.
- Add component and browser regressions covering long values, wide/narrow layouts, clipboard contents, execution flows, and fixture cleanup.
- Document repair evidence separately from deployed-image acceptance. Corrected Azure image validation and operator visual approval remain pending; customer production is unchanged.
| File | Description |
|---|---|
web/src/pages/BulkTab.tsx |
Bounds grid tracks and reuses copyable, truncated result fields. |
web/src/pages/BulkTab.test.tsx |
Checks complete long values and copy controls. |
web/e2e/bulk-and-manual-execution.spec.ts |
Adds layout, clipboard, execution, and cleanup coverage. |
Session_starter.md |
Records the migration checkpoint and pending repair acceptance. |
docs/UI_GUIDE.md |
Describes unreleased truncation and copying behavior. |
docs/TENANT_10_MIGRATION_EXECUTION_2026_10_30.md |
Records deployment evidence, repair results, and execution issues. |
docs/strategy/ENGINEERING_LESSONS_AND_PATTERNS.md |
Documents deterministic long-value layout testing. |
docs/PHASE_M2_BULK_OPERATIONS.md |
Explains the repair and its verification boundaries. |
docs/GLOBAL_NAVIGATION_AND_WORKFLOW_CONTEXT.md |
Clarifies that copying preserves navigation and endpoint selection. |
docs/CONTEXT_INSTRUCTIONS.md |
Updates migration status, validation evidence, and remaining gates. |
CHANGELOG.md |
Adds the unreleased repair summary and validation results. |
Review effort: Balanced
Owner
Author
|
The existing migration-only performance admission T10-0.55.67-PERF-EXCEPTION-2026-11-03 is now bound to the reviewed Bulk repair:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the unintended narrow-viewport Bulk result overflow found during tenant 10 acceptance. Bound the flexible grid tracks and reuse existing copy/truncate fields without changing request/response semantics or rewriting visual baselines.
This is a frontend-only repair for the operator-authorized 0.55.67 dev/canary migration. Performance remains UNQUALIFIED under
T10-0.55.67-PERF-EXCEPTION-2026-11-03; no other gate is waived and customer production must not change. Version, API runtime, schema, dependencies, lockfiles, workflows and qualification rules are unchanged.The current Azure image remains the reviewed
6102aff4artifact. This patch is tested on an owned built-loopback frontend with migrated-dev backend, not yet deployed. A reviewed merge, corrected immutable image, updated source/digest binding and complete actual target reruns remain mandatory.Linked Defect / Plan Reference
TDD Process
api/src/security/). Long-value fixture measures 1440/900 px bounds, actual truncation and full clipboard values.Feature / Bug-Fix Commit Checklist (standing rule)
Every behavioral change must include all that apply. Tick or strike through with N/A + reason.
api/test/e2e/exercising the feature through HTTP. N/A for unchanged API; browser spec verifies real bulk creation, duplicate/conflict, retry, failure CSV and cleanup, plus deterministic layout.scripts/live-test.ps1runnable against local + Docker + Azure. N/A for frontend layout; existing actual dev live run reports 1,841 passes, zero failures, with four explicit retired-API placeholders not claimed as exercised checks. Corrected-image target acceptance remains pending.docs/with architecture, RFC references, Mermaid diagrams, test coverage. Refresh existing Bulk guide and record failure/repair provenance.docs/INDEX.md. N/A: existing indexed feature document updated, no new feature document.[Unreleased]entry with full test counts and feature summary.Session_starter.mdanddocs/CONTEXT_INSTRUCTIONS.md.api/package.json(and any other version refs) when behavior changed. Deliberately retain 0.55.67 for the operator-authorized migration repair; no new public release or customer-prod promotion.Validation Output
The actual Azure full browser failure is preserved: 347 passes, one unintended layout failure, zero skips/flakes, 1,037.046s. Failure and corrected screenshots were inspected; no diff PNG was generated and no visual baseline was regenerated. Earlier successful source/image/live evidence is not relabeled as corrected-image acceptance.
The separate numeric-settings acceptance spec remains outside this focused commit.
Standing Rules Acknowledgment
U+2014) anywhere in the diff. Verified viaSelect-String -Pattern ([char]0x2014). Authored additions are ASCII; protected static verification remains mandatory.git commit --amendon history that has been pushed.api/src/security/forbidden-source-patterns.spec.tswill catch known anti-patterns.api/src/scripts/lint-migrations.tsenforces this. N/A: no migrations.Destructive Migration Override (skip if not applicable)
N/A: no schema or migration change.
ALLOW_DESTRUCTIVE_MIGRATION=1in the CI environment for this PRReviewer Hint
Diff areas worth special attention from the reviewer: