Repository navigation
fix: restore complete API npm inventory with shared override contexts (0.55.63) - #260
Conversation
Reserve independent 0.55.63 from master, without draft web 0.55.62. RED/GREEN full-tree regression includes the tightly coupled hasown context. Bootstrap source for CI-owned lock regeneration; not release qualification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CI run 40913629689, artifact 12914787144, archive SHA256 bad38ee1bd6a8fed20170e71aa8090d589ed0785d449525da91873b123c09d21. Zero non-root changes in both graphs. Serial clean restores preserve hashes; actual full API npm inventory exits 0 and focused checks pass 38/38. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@copilot Please provide an actual code review of exact head 6eb1b59. This draft is one independent API override-context rollback unit, with four same-version shared root pins and a real complete-tree npm regression. Check every installed owner and the authenticated zero-churn CI locks. The reviewer request returned success but the review, thread and pending-request collections remain empty; acknowledgment is not review approval. Keep the PR draft and do not merge or deploy. |
Authenticate regeneration 40963173363 at d6b8044 and artifact 12935469827 before import. Preserve every non-root API/web entry and coordinate both roots at 0.55.63. Record integration RCA and bounded archive-path recovery. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Refreshed independent technical review of the integrationExact reviewed head: Result: no significant introduced defects found. The bounded refresh independently verified:
The reviewer did not execute tests, builds or installs, and did not This author-posted receipt records an independently executed automated |
Summary
Restore actual API
npm ls --all --jsonacceptance with four shared exactroot overrides at existing locked versions, without changing package versions.
Product 0.55.63 now normally integrates reviewed web #259's merged master,
0a9b3d04535dc51dcfc58e9a2360c1c9e112a41a, while preserving the originalAPI correction
6eb1b59cand every constituent commit. The API graph retainsits four root overrides; the web graph inherits merged Seroval 1.6.11 and
Undici 7.30.1. No new application, auth, UI, schema or performance
implementation is added.
Current integration head:
15618fffd7d1ff4e206b68c8c0bdacbe173a83b7.Final protected Validate, refreshed independent review and all seven
exact-head hosted checks pass. This is not deployment or release
artifact admission. Historical independent-branch results below are labeled
and are not substituted for the integrated head's evidence.
Linked Defect / Plan Reference
docs/API_OVERRIDE_CONTEXT_VALIDITY.md, including execution RCA and independently preserved RED/GREEN inventories.TDD Process
api/src/security/)Initial RED: 4 failed /3 passed (three missing shared contexts and real full-tree inventory).
After three pins: real inventory still fails for hasown, reproduced after clean restore.
Fourth-pin RED: 2 failed /7 passed; final GREEN: 9 new +29 existing checks, 38 PASS.
The tests enumerate every real owner, compare installed owner ranges, resolve
actual installed versions, verify all lock occurrences/provenance, require one
exact root context per package and execute the real full npm command.
Feature / Bug-Fix Commit Checklist (standing rule)
Every behavioral change must include all that apply. Tick or strike through with N/A + reason.
api/test/e2e/exercising the feature through HTTP. N/A additions: no HTTP change; existing broad HTTP gate retained.scripts/live-test.ps1runnable against local + Docker + Azure. N/A: no live behavior or estate mutation.docs/with architecture, RFC references, Mermaid diagrams, test coverage. Dependency-only mechanism, owner table, flow, TDD, RCA and boundary documented; no SCIM RFC or diagram behavior changed.docs/INDEX.md[Unreleased]entry with full test counts and feature summarySession_starter.mdanddocs/CONTEXT_INSTRUCTIONS.mdapi/package.json(and any other version refs) when behavior changed. Both roots 0.55.63; CI-only lock roots and freshness headers aligned.Validation Output
Current integrated source
d6b8044dpreserves API6eb1b59cand reviewedweb master
0a9b3d04; no rebase, squash, amend, force or hook bypass.$env:PREPUSH_MODE='Fast'; git push origin fix/api-override-context-20261029:PASS, 25/25 gates in 503.1 seconds; API 6,229/214 suites; HTTP 2,514/118
suites plus the existing 42 skipped tests.
npm --prefix api ci --no-audit --no-fundandnpm --prefix web ci --no-audit --no-fund: PASS, existing CI lock hashesunchanged. The final imported locks have the identical non-root graph.
40963173363:
PASS at exact source
d6b8044dfd4fb28ab61c2ac7de7a49789e828492.Artifact
12935469827, authenticated ZIP SHA-2560c955883595cfe75041e6bb135b60132430d96f64d9d9f8ceb3f4422642a69f7,verified before extraction. Both roots are 0.55.63, with zero non-root
drift. The seven-day publication-age report has no changed packages.
correction; web graph equals merged fix: remediate web Seroval and Undici pins (0.55.62) #259. No local lock generation.
at exact
15618fffagainst0a9b3d04; parent-union graphs, coordinatedroots and committed lock hashes independently checked. No test execution
or GitHub approval is claimed by this review.
$env:PREPUSH_MODE='Validate'; git push origin fix/api-override-context-20261029:PASS, 28/28 gates in 989.4 seconds, exit 0. Published exact head is
15618fffd7d1ff4e206b68c8c0bdacbe173a83b7; working tree remains clean.API units: 6,229 passed /214 suites. HTTP: 2,514 passed /118 suites,
plus 42 existing skipped tests /2 skipped suites. Web: 1,661 passed
/125 files, including the six inherited merged-web regressions.
API/web TypeScript, lint, production build, Mermaid rendering, provenance,
documentation, Prisma generation and additive migration checks all pass.
Existing Windows worker teardown warnings remain explicitly unresolved;
no worker, timeout, forceExit, test exclusion or baseline was changed.
checks successful:
push Build Test Image 40965922000,
PR Build Test Image 40965931480,
CodeQL 40965931015
and docs freshness 40965931172.
Both builds pass their validation, container smoke and HIGH/CRITICAL
Trivy steps. The independently built test-image digests are:
push
sha256:a16b558c82311d6c8148cf2d1f8f1eadfd9f890ffb072607b23554c3d28491c5;PR
sha256:0610d0f7c7da72ed6bb0efeb66464bc5432473dbb716780ff706a0fe5ad01bc3.Neither is a final merged release artifact or deployment.
comment 6509821300.
No unresolved review threads were present. Required branch protection
remains unchanged; no admin bypass or approval fabrication is used.
moving only three generated files into the owned worktree. No
other-worktree source file was edited; RCA and prevention are documented.
Historical independent API candidate
The following measurements and image digests belong to original head
6eb1b59c, before web #259 was integrated. They remain provenance, notproof for
15618fff.Exact executed commands and their separate evidence:
npm --prefix api test -- --runInBand src/scripts/check-dependency-override-context.spec.ts: expected RED, then GREEN after the minimal pins.npm --prefix api test -- --runInBand src/scripts/check-dependency-override-context.spec.ts src/scripts/check-dependency-pins.spec.ts: PASS, 38/38 after CI-lock restore.npm --prefix api ls --all --json: EXIT 1 before correction; EXIT 1 for the coupled hasown context after three pins and clean restore; EXIT 0 after final authenticated-lock restore.npm --prefix api ci --no-audit --no-fund: PASS; API lock hash byte-identical.npm --prefix web ci --no-audit --no-fund: PASS, serialized; web lock hash byte-identical.npm run docs:freshness:fix,npm run docs:content,npm run rfcs:check: PASS after updating the README version badge caught by the cheap content preflight.node scripts/check-lockfile-provenance.mjs: PASS.$env:PREPUSH_MODE='Validate'; git push origin fix/api-override-context-20261029: PASS, 28/28 unchanged gates at6eb1b59cb1a8ea324bb1a32b17355fabc605279d. API/web TypeScript, web production build, doc rendering/provenance/currency, Prisma generation, additive migration linter and existing unit/HTTP/web suites all PASS. The checked-in build-test DATABASE_URL prerequisite was supplied only in the process environment without printing it.scripts/assert-dependency-ownership.ps1 -RepositoryRoot <owned-worktree>: PASS before restore/build; physical in-scope node_modules, no linked dependency mutation.npm --prefix web ls --all --json: EXIT 0; existing master Seroval 1.6.3 and Undici 7.29.1 deliberately remain outside this correction.npm --prefix api run check:pins: EXIT 1, 31 API pins checked /6 advisory records, 8 web pins /13 records, zero unchecked. This is not advisory clearance: the independent web remediation is draft fix: remediate web Seroval and Undici pins (0.55.62) #259 and the six API records remain separate.Clean CI-only lock provenance:
regen-lockfile.yml, successful run 40913629689, exact bootstrap sourcec9cddb3dfdbb1b7b022ce39404f647c9782006db.12914787144, authenticated ZIP SHA-256bad38ee1bd6a8fed20170e71aa8090d589ed0785d449525da91873b123c09d21, verified before import.0dd66eb53bc7c508cbbef80dc63417ef7178bf9a36f44066299b03f2634b3fb3.fc6121573eb5de28bbc2a70b9f9d9c2eae16d54f660628d7a33d0a2b34269899.All repository workflows below completed SUCCESS at exact source
6eb1b59cb1a8ea324bb1a32b17355fabc605279d:Hosted tests independently include the new real-inventory regression.
Both immutable test images were smoke-tested at their own digest:
push
sha256:f80c9c633b5611ff42f051ddcae3e9b0b489e8aa18d3823659e307188ab92e62;PR
sha256:42cf3d416a6c1cc73f150f562340cf37b1950fa40ffd43c20c75d75aec6f2bdc.These are separate builds of one source, not a promoted or latest candidate.
Image scan success does not clear the held browser/API advisories.
Standing Rules Acknowledgment
U+2014) anywhere in the diff. Verified viaSelect-String -Pattern ([char]0x2014).git commit --amendon history that has been pushed.api/src/security/forbidden-source-patterns.spec.tswill catch known anti-patterns.api/src/scripts/lint-migrations.tsenforces this. No migration changes.Destructive Migration Override (skip if not applicable)
ALLOW_DESTRUCTIVE_MIGRATION=1in the CI environment for this PRReviewer Hint
Diff areas worth special attention from the reviewer:
npm lsor diff summary.test-results/integration-api-web-20261029/. Original independent receipts remain intest-results/api-override-context-20261029/; neither older bootstrap nor independent image results substitute for final exact-tip qualification.Historical hosted-review request evidence:
gh pr edit 260 --add-reviewer '@copilot'returnssuccess, but actual reviews, threads and pending requests remain empty.
The single ordinary
@copilotfollow-up comment triggered platformAddressing comment on PR #260run 40917030477,which FAILED before a review with
You have exceeded your monthly quota.This failed comment automation is separate from repository CI and is not
review approval. No further comment/request loops or quota bypass will run.
The canonical policy requires green independent review and CI, not a
particular hosted reviewer. A separate exact-head technical review is
recorded transparently; it is not a fabricated human or GitHub approval.
The integration's refreshed review and exact-head CI must be green before
ordinary merge. No repository protection or required check is removed.