Skip to content

Created Modals for Latex command - #179

Merged
Xarlos89 merged 3 commits into
masterfrom
Fix/Latex_improvements
Aug 23, 2026
Merged

Created Modals for Latex command#179
Xarlos89 merged 3 commits into
masterfrom
Fix/Latex_improvements

Conversation

@JefeThePug

Copy link
Copy Markdown
Collaborator

Made Latex editable without spamming the channel using Modals

Describe your changes

slash command -> modal -> embed where user can initialize the /latex command with a slash command, edit it as much as they like in the modal, with preview of how it will look, and a "publish" button which sends it to the chat as an embed. All modals and previews are ephemeral to avoid spamming the chat with mistakes.

Added

  • Invalid Equation image to appear during editing when the typed LaTeX equation is not renderable
  • _latex_utilities.py to store the Modal classes for editing Latex equations.

Fixed

  • latex.py to have the slash command open a Modal where the user can edit their LaTeX submission before publicly sending it to the channel.

Changed

Small Concern

  • Looking at my Docker logs, it seems like the logging is not working but nothing in my edited code seems to have anything to do with it and I am never referencing the .id attribute of anything.
2026-08-23 20:24:00 :: 08-23 11:24.00 :: ERROR :: client.py line 582 --- Ignoring exception in on_message_edit
2026-08-23 20:24:00 Traceback (most recent call last):
2026-08-23 20:24:00   File "/bot/.venv/lib/python3.12/site-packages/discord/client.py", line 508, in _run_event
2026-08-23 20:24:00     await coro(*args, **kwargs)
2026-08-23 20:24:00   File "/bot/src/bot/cogs/logging/logging_message_edit.py", line 57, in on_message_edit
2026-08-23 20:24:00     message_before.guild.id != int(os.getenv("MASTER_GUILD"))
2026-08-23 20:24:00     ^^^^^^^^^^^^^^^^^^^^^^^
2026-08-23 20:24:00 AttributeError: 'NoneType' object has no attribute 'id'

Checklist

  • Have your ran pre-commit over your PR?
  • Was this PR branched off from master?
  • Is this PR merging to master?

Made Latex editable without spamming the channel using Modals
Xarlos89
Xarlos89 previously approved these changes Aug 23, 2026

@Xarlos89 Xarlos89 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor things with defer and potential issues with slow APIs, but if it's not an issue then it's not an issue. Approved from my side.

Comment thread src/bot/cogs/features/latex.py
Comment thread src/bot/cogs/features/_latex_utilities.py
Comment thread src/bot/cogs/features/_latex_utilities.py
Added defer() where requested and adjusted the interaction methods accordingly.
@Xarlos89
Xarlos89 merged commit d53ab05 into master Aug 23, 2026
2 checks passed
@Xarlos89
Xarlos89 deleted the Fix/Latex_improvements branch August 23, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants