Send sync status updates over broadcast channel when shared workers are disabled - #1047
Merged
Conversation
🦋 Changeset detectedLatest commit: 583f493 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simolus3
marked this pull request as ready for review
July 27, 2026 13:04
Chriztiaan
reviewed
Jul 27, 2026
simolus3
force-pushed
the
broadcast-sync-status-updates
branch
from
July 27, 2026 14:29
4cb53b2 to
32d08d8
Compare
Chriztiaan
previously approved these changes
Jul 27, 2026
Chriztiaan
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To coordinate the sync process across tabs, we prefer to use shared workers. Shared workers are broken and disabled by default on Safari though, we also disable them on mobile. In these cases, each tab would attempt to sync on its own, with most tabs blocked on the navigator sync lock, leaving an app stuck waiting for
hasSynced.As a minor improvement, this makes the connected tab send its status update through a broadcast channel that other tabs trying to connect will listen to. So download progress and fields like
hasSyncedare then shared across tabs, and it appears like all tabs make sync progress similar to the setup with shared workers. Additionally, stream subscription changes from any tab are also broadcast to update the sync client in the active tab.This solution is not perfect, being able to rely on shared workers would definitely be better. But it's still an improvement and provides limited multi-tab support even without shared workers.