Skip to content

[HFH] Prevent acceptance criteria comment recursion #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garettarrowood merged 1 commit into from
Jul 27, 2026
+7 −6
Merged

[HFH] Prevent acceptance criteria comment recursion #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions agentic-acceptance-criteria/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ The raw `acceptance-criteria-agent.json` file is uploaded as an artifact for deb

## Secrets and permissions

The calling workflow needs `contents: read` and `pull-requests: write`. The GitHub App installation must be able to clone the target repository and create or edit its PR comments.
The calling workflow needs `contents: read` and `pull-requests: write`. The GitHub App installation token is used to read PR metadata and clone the target repository. PR comments use the calling workflow's `GITHUB_TOKEN` so action-authored comments do not trigger recursive `issue_comment` workflow runs.

The action can reuse the same secrets as `agentic-pr-review`:

Expand Down Expand Up @@ -76,7 +76,7 @@ permissions:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.issue.number || github.ref }}
cancel-in-progress: true
cancel-in-progress: false

jobs:
acceptance-criteria:
Expand Down
9 changes: 5 additions & 4 deletions agentic-acceptance-criteria/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ runs:
- name: Post in-progress status comment
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
github-token: ${{ steps.app_token.outputs.token }}
# GITHUB_TOKEN-authored comments do not trigger recursive issue_comment runs.
github-token: ${{ github.token }}
pr-number: ${{ inputs.pull-request-number }}
comment-tag: agentic-acceptance-criteria-status
mode: delete-on-completion
Expand Down Expand Up @@ -146,7 +147,7 @@ runs:
id: acceptance_criteria_comment
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
github-token: ${{ steps.app_token.outputs.token }}
github-token: ${{ github.token }}
pr-number: ${{ inputs.pull-request-number }}
comment-tag: agentic-acceptance-criteria
mode: upsert
Expand All @@ -156,7 +157,7 @@ runs:
continue-on-error: true
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
github-token: ${{ steps.app_token.outputs.token }}
github-token: ${{ github.token }}
pr-number: ${{ inputs.pull-request-number }}
comment-tag: agentic-acceptance-criteria-failure
mode: delete
Expand All @@ -166,7 +167,7 @@ runs:
if: failure() && steps.acceptance_criteria_comment.outcome != 'success'
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
github-token: ${{ steps.app_token.outputs.token }}
github-token: ${{ github.token }}
pr-number: ${{ inputs.pull-request-number }}
comment-tag: agentic-acceptance-criteria-failure
mode: upsert
Expand Down
Loading