Repository navigation
Make the UpgradeRoots pass test root specifiers lazily - #94
Merged
Merged
Conversation
The pass tested every published version of every root against the root's specifiers, even when no root was behind. Test only versions above a pin, and score the first answer only when a re-solve returns. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…el scoring Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UpgradeRoots pass tested every published version of every root against the root's specifiers, in every resolution, even when no root was behind. Now it tests only versions above a root's pin, and scores the first answer only when a re-solve returns. Results are unchanged.
TestUpgradeRootsTestsSpecifiersOnlyAbovePinscounts specifier tests through a test hook: 0 when no root is behind (60 with an eager pass, which is RED), and at most the versions above the pin when one is.resolver/upgrade.goonly (plus a test hook and CHANGELOG).🤖 Generated with Claude Code