Repository navigation
Give a run of one the gap to the next published version (rstudio/package-manager#22613) - #100
Merged
Merged
Conversation
…age-manager#22613) Adjacent turned-down versions then merge into one span. Pins and failures are unchanged; two failure explanations in the golden get shorter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…anager#22613) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A depender version that forms a run of one (no identical neighbour) now covers the gap up to the next published version, so learned conflicts of adjacent turned-down versions merge into one span instead of one span each. Fixes two real PPM out-of-memory solves. For rstudio/package-manager#22613.
Why it is sound
vis now[v, next published version).[v]excluded.Measurements
Measured in PPM (f8679e25ba) with base = v0.21.0 and new = this change on v0.21.0 (go-pubgrub v0.5.0), before the merge with v0.22.0/v0.23.0. Production cache sizes, 6 GB container, 8 CPUs, machine under load. RS = RunningSatisfier.
The anndata pins equal uv's exactly. On the 09-27 RSF there is no gain on f1 (2.3 -> 2.3 s), s1 (noise) or s2-105 (both builds hit the 5-minute deadline), and a small gain on s3-400 (RS on 30.9 -> 27.1 s, off 20.5 -> 16.9 s). Same pins, failures and warnings in every pair; heap peaks within noise. Rounds and
Dependenciescalls do not drop: the gain is smaller learned clauses.scanpy: uv pins 95, PPM 94. On Python 3.11 PPM picks anndata 0.12.6 where uv picks 0.12.19 + scverse-misc 0.0.3.
s3fs+scanpy+anndata==0.12.6resolves in uv, so PPM's answer is valid but older; it comes from PPM's curated layer, not this change (base never finishes this case).Parity
114 + 111 environment sets on the 09-27 and 11-12 RSFs: no pin differences. Every differing cell is failure text only (shorter explanations), in 6 sets per run. Some cap reruns (sets that hit the 4.5 GB harness cap in one build only) were not finished.
Checks
go test -race ./...and golangci-lint (0 issues) pass after merging origin/main.audit.sh, scoped to this worktree): PASS, no known reference retrieved in 236 sessions. Process finding only; it says nothing about model weights. Two cross-repo notes are downloads of the uv release binary, not source.🤖 Generated with Claude Code