Skip to content

Deduplicate parsing #608

Open
Open

Description

@teunbrand

This issue is an extract from #558 (comment)
We parse and build the AST several times. If we look at execute_with_reader():

  • It builds the source tree, builds the AST for dispatch purposes and calls validate()
  • validate() itself also rebuilds the source tree and the AST internally (for the 2nd time)
  • execute_with_reader() passes the query on prepare_data_with_reader(), not the source tree / AST that were already build. It also does parsing and AST building (for the 3rd time).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions