Harden Bedrock credentials and preserve AWS region provenance - #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #49 with two commits that were made locally after that PR's branch was last pushed, so they missed the squash merge:
update-awsvariant toCredentialMutationinai-credentials(region/profile update with replace/clear/preserve semantics for manual keys), implements it in the store backend, and hardens the Bedrock provider's inference-profile discovery and credential handling.ai-confignow exposesconnectionProvenanceon resolved providers, recording whether the effective AWS region came from deliberate configuration or only ambientAWS_REGIONenv. Downstream (assistant monorepo) uses this so a region-only shell setting doesn't mark Bedrock as configured.These changes are required by the assistant monorepo's
aws-regionswork (posit-dev/assistant#2002); itspackages/nodeauth code already referencesupdate-awsandconnectionProvenance.