Installed apps: the launch/<app-id> kind, and "Install as app" - #180
Merged
Conversation
A web app manifest's start_url is written once into the OS's registry and replayed for months; the sealed app/ token fits that badly — its opacity hides what the launcher shows, and its key binding turns a route-key convergence into an installed app that opens to a refusal. So an install opens at `launch/<package>`: plaintext, keyless, resolved by route-decode to this user's install at route "". The bar switches to app/ once the frame is up. shell.install-app mints a manifest per package with id, start_url and scope written absolute against the page's base (never `/`, which on a project Pages site is somebody else's page), an icon of the user's glyph on the user's hue, and calls the prompt the browser offers for that manifest — not one it offered for an earlier one. e2e: launch-fragment-opens-app, install-app-manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A web app manifest's start_url is written once into the OS's registry
and replayed for months; the sealed app/ token fits that badly — its
opacity hides what the launcher shows, and its key binding turns a
route-key convergence into an installed app that opens to a refusal.
So an install opens at
launch/<package>: plaintext, keyless, resolvedby route-decode to this user's install at route "". The bar switches to
app/ once the frame is up.
shell.install-app mints a manifest per package with id, start_url and
scope written absolute against the page's base (never
/, which on aproject Pages site is somebody else's page), an icon of the user's
glyph on the user's hue, and calls the prompt the browser offers for
that manifest — not one it offered for an earlier one.
e2e: launch-fragment-opens-app, install-app-manifest.
Gates:
just ci,just e2e22/22. Automerge armed.Unverified (needs a real install, which Playwright cannot drive): that Chromium keeps the fragment in
start_url; the design record names?launch=as the fallback for this kind.