Devices: a tab with no anchor adopts the last kept device - #179
Merged
Conversation
The anchor is per tab, so a typed URL, a bookmark or an installed app's window minted a fresh device every time — "new tab, new stranger" — and a user's own bookmark opened in a new tab of the same profile was refused, because the fresh device held no route key. The glue now keeps one more pointer in localStorage: the last device `device.status` reported as durable. A tab with no anchor adopts it; only a profile with no kept device, or an explicit `switch-device(none)`, mints. e2e: bookmark-in-a-new-tab; two-devices-entry distinguishes a lost anchor (re-adopts) from an explicit new device (picker).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anchor is per tab, so a typed URL, a bookmark or an installed app's
window minted a fresh device every time — "new tab, new stranger" — and
a user's own bookmark opened in a new tab of the same profile was
refused, because the fresh device held no route key. The glue now keeps
one more pointer in localStorage: the last device
device.statusreported as durable. A tab with no anchor adopts it; only a profile with
no kept device, or an explicit
switch-device(none), mints.e2e: bookmark-in-a-new-tab; two-devices-entry distinguishes a lost
anchor (re-adopts) from an explicit new device (picker).
Gates:
deno task check,deno task test,just e2e20/20. Automerge armed.