Visor: the drawer opens above the strip, in flow - #173
Merged
Conversation
The strip always separates visor content from app content, so whatever the visor opens goes on its side of that line and pushes the strip down rather than covering the app. The "strip geometry immobile" gate that justified the overlay in #171 is struck: from design.md M1, the page comment, and the two e2e equality assertions (the 56px height check stays).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #171's overlay geometry: the drawer is back in normal flow above the strip, so the strip is always the boundary between visor and app content. Strikes the "strip geometry immobile with the app mounted" claim from design.md M1, index.html, and the e2e harness (height pin kept). 18/18 e2e locally. Automerge armed.