TodoMVC emits its stylesheet: asset-valued <link> via the upstream asset:<hex> spelling - #170
Merged
Merged
Conversation
…set:<hex> spelling
The Pages demo rendered unstyled: the app bundle shipped its CSS as an
asset and the frame minted a blob: URL for it, but the app never emitted
the <link> because stream-dom-dioxus had no way to spell an asset handle
in a string attribute value. polymorph-stream-dom#19 added one; bump the
pin and emit link { rel: stylesheet, href: asset:<handle> }. A unit test
pins the const to manifest.json; frame-network-dead now ignores the blob:
load and asserts the stylesheet applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the unstyled TodoMVC on the Pages demo.
The bundle already shipped
todomvc-app.cssas a content-addressed asset and the frame already minted ablob:URL for it under the policy that only allows asset-valued<link href>. The app never emitted the<link>becausestream-dom-dioxusreduced every attribute value to text (the CONTRACT comment inapps/todomvc/src/lib.rs). polymorph-components/polymorph-stream-dom#19 adds anasset:<hex>spelling for attribute values; this PR bumps the pin to that commit and emits the link.Cargo.toml/deno.jsonpins →e35dc357(lockfiles: only the stream-dom entries move)apps/todomvc:link { rel: "stylesheet", href: STYLESHEET }; a unit test keeps the const equal tomanifest.json's handlee2eframe-network-dead: theblob:stylesheet load is not network, filter it; assert.todoappis actually whitedocs/design.mdpin table noteGates:
just ci,just e2e(17/17) pass locally. Automerge armed.