visor: move to the top of the page, drawer above the strip - #162
Merged
Conversation
Users know trusted UI at the top from browsers, and visor interactions are rarer than app interactions, so the strip leaves thumb range on a handheld. The drawer sits above the strip and pushes it down when open: the strip is the line between trusted pixels and the app zone, and nothing the visor opens goes on the app's side of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visor moves from the bottom of the page to the top, and the drawer opens above the strip rather than below it.
Changes:
web/index.htmlswaps#visorand#app-zone;visor/src/ui.rsrenders the drawer before the strip;visor/src/style.rsflips the two separators toborder-bottom.Verified with Playwright at 420x760: strip at y=0 closed (56px), y=70.6 with Apps open, y=0 again once an app mounts (launch closes the drawer), y=456 with Settings open over a running app. The existing e2e geometry gates (
open-app,frame-violation-ends-session) compare drawer-closed states and are unaffected.Automerge is armed.