boot: derive the home origin from the page URL, not location.origin - #161
Merged
Conversation
A GitHub Pages project site is served under /<repo>/, so the kernel's
{home-origin}/apps/index.json fetch went to the host root and 404ed.
Every other URL the tab and worker resolve is already relative to
location.href; the hello now matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Pages deploy every device failed to boot:
The site is a project Pages site under
/polyvisor/, butweb/boot.tssent the kernellocation.originasboot-config.home-origin, dropping the path. The kernel fetches{home-origin}/apps/..., so those went to the host root. Everything else the tab and worker load (config.json,worker.js, the components) is already resolved relative tolocation.href, which is why only the app registry broke.Fix: hand the kernel the page's directory URL (
new URL(".", location.href), trailing slash stripped). Yields the bare origin for a root-served site (the e2e harness), so nothing changes there. Theinternal.witdoc and a stale worker comment that assertedlocation.originare updated.Gates:
deno task check,deno fmt --check.Automerge is armed.