polymorph-test 0.3.1; one wit-bindgen line (0.61) - #56
Merged
Conversation
polymorph-test 0.3.1 moved to wit-bindgen 0.61 and wasmtime 48, and wasip3 0.8 is 0.7's WIT on wit-bindgen 0.61, so the workspace can sit on a single async wit-bindgen line: the workspace dep goes to 0.61 and the tls-tcp / tls-component-bench 0.57 pins become workspace deps. The two bumps land together because either alone splits conformance guest-ct from the SDK's line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polymorph-test v0.3.1 (rev
3631d4a1) is on wit-bindgen 0.61 / wasmtime 48, and wasip3 0.8 is wasip3 0.7's WIT rebuilt on wit-bindgen 0.61. Together they let the workspace collapse its two async wit-bindgen lines (0.57 for the wasip3 guests, 0.60 for everything else) into one:component-test pins bump, JSR pin,npm install, regenerateddeno.lock).wit-bindgen0.61 /wasip30.8 in the workspace;tls-tcpandtls-component-benchdrop their 0.57 pins forworkspace = true.guest-ct's comment no longer embeds the version number; the invariant is stated once at the workspace dep.The two bumps are one PR by necessity: the pin bump alone puts
guest-ct(0.60) on a different line from the SDK (0.61); the wit-bindgen bump alone does the reverse.Remaining
wit-bindgen 0.57.1in the graph iswasip2's sync-only bindings (bitflagsfeature, no async runtime) viagetrandom/wasi— not a second runtime.Gates:
just check,runner-js-pin-check(0.3.1),CONFORMANCE_BROWSER=1 just conformance(7 targets, 42 results, 0 failing, matrix unchanged),just smoke-tls-virt,just interop-tls— all green locally.Automerge armed.