tls-virt-wasmtime: run the sandbox address check on tunneled connects - #55
Merged
Conversation
The address check is the embedder's closure (WasiCtxBuilder:: socket_addr_check), so the host keeps its own handle to it and runs it against a tunnel's real destination before dialing, on both sockets generations. Delegated sockets and tunnels share one policy; the policy itself stays allow-all here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sandbox address check is a closure the embedder installs (
WasiCtxBuilder::socket_addr_check;inherit_network()is that with|_, _| true), so the host already has it.VirtCtxnow holds the sameArcthat is installed on theWasiCtx, and both tunnel paths run it against the resolved real destination before dialing: inline in the 0.3connect, inside the spawned dial task on the 0.2start-connect(a deny surfaces throughfinish-connectasaccess-denied). Delegated sockets and tunnels share one policy.The policy in this host is still allow-all (no CLI knob) — the change is the structure, which is what #16 item 13 asks for. README finding reworded accordingly; the "tunnels bypass the address check" limit is gone.
Gates: fmt, clippy
-D warnings,just smoke-tls-virt-wasmtime(all four legs).Automerge armed.