desktop: drop the bundle resource declaration so clippy runs before the component exists - #17
Merged
Conversation
…he component exists tauri-build fails if a declared bundle.resources path is missing, and `just check` runs before `just components`. The app is never bundled; `just desktop` already copies the component beside the binary, which is where resource_dir() points for an unbundled build.
…tendDist to exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
gatesjob from #16:tauri_build::try_buildpanics when a declaredbundle.resourcespath is absent, andjust checkruns before the component is built. The app is never bundled andjust desktopalready copies the component beside the binary (whereresource_dir()resolves for unbundled builds), so the declaration did nothing but fail early. Verified locally: clippy withbuild/absent, andjust desktop-smoke.