runtime: deno fmt the package and gate it (just fmt-check) - #316
Merged
Conversation
The runtime had no formatter gate and 124 of 214 files disagreed with stock `deno fmt`. One-time reformat, then keep it that way: - `just fmt-check` (`cd runtime && deno fmt --check`), a dependency of `check` and `gates` and a step of `gha::core`. - runtime/deno.json excludes the generated bindgen snapshots and envelopes (tests/bindgen/generated, tests/bindgen/fixtures) and the generator's output (tests/fixtures): generated artifacts are not for hand formatting. - suspending_imports_test.ts: the `@(suspending as any)` decorator spelling is rewritten by dprint into invalid syntax; bind the untyped alias to a const and decorate with that instead. Whitespace-only otherwise; `just test-runtime` 739 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #315's report. The runtime had no formatter gate anywhere (justfile, CI, or
deno.json) and 124 of 214 files disagreed with stockdeno fmt. This is the one-time reformat plus the gate that keeps it that way.just fmt-check=cd runtime && deno fmt --check; a dependency ofcheckandgatesand a step ofgha::core(cheap, runs right after the version guards).runtime/deno.jsongains anfmt.excludefor the generated bindgen snapshots and envelopes (tests/bindgen/generated,tests/bindgen/fixtures) and the generator's output (tests/fixtures): generated artifacts are not for hand formatting, and reformatting them would drift from their generators.suspending_imports_test.ts: dprint rewrites the@(suspending as any)decorator into@suspending as any, which does not parse. Bound the untyped alias to a const and decorate with that; the test's assertion is unchanged.Everything else is whitespace/line-wrap only.
just test-runtime: 739 passed, 0 failed.deno.lockuntouched. Scope is the runtime package only; the other workspace members are unchanged (they can follow the same pattern if wanted).Automerge armed.