wasi/cli: restore cli({ passthrough }) — a consumer depends on it - #308
Merged
Conversation
2e2b72e (the incidental-complexity sweep) deleted `CliOptions.passthrough` as a speculative hedge. It was not: lann/wosh (site/polyengine-entry.ts) passes `passthrough: true` because its guest's stderr is the only diagnostic channel it has, and a buffered stderr nobody reads is a black box exactly when the network is misbehaving. The sweep's consumer check covered ~/p/polymorph only and missed wosh. Restored as it was (0.2 OutputStream sink and 0.3 write-via-stream both mirror to console.log/console.error; default off), plus a test that pins it so the next sweep sees in-repo evidence of use. Compatible addition; no breaking label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2e2b72e(the incidental-complexity sweep, #260) deletedCliOptions.passthroughas a speculative hedge. It was not: lann/wosh (site/polyengine-entry.ts) passespassthrough: truebecause its guest's stderr is its only diagnostic channel, and a buffered stderr nobody reads is a black box exactly when the network is misbehaving. The sweep's consumer scan covered~/p/polymorph/only and missed wosh (still pinned to@polyengine/wasi@0.5.1, so it breaks on upgrade rather than today).Restored as it was: 0.2
OutputStreamsink and 0.3write-via-streamboth mirror toconsole.log/console.error; default off. Plus a test pinning both tracks and the default-off case, so the next sweep finds in-repo evidence of use.Compatible addition; no breaking label. Gates:
just test-wasi(281 pass),just version-guard-local.Automerge armed.