review follow-ups: driveSyncLift candidate set, cancel-copy divergence named, sync-pump reentrancy pinned - #307
Merged
Merged
Conversation
…e named, sync-pump reentrancy pinned #299 — `driveSyncLift` excluded `inst.exclusiveThread` from its candidate set; the pinned reference (`canon_lift` 2190-2192, post-CM#705) has no such exclusion. Inert today (plain mode only; a frame cannot park mid-loop) but wrong the day it is lit. Exclusion dropped, stale "line 2213" citation fixed, unused `exclusiveThread` field removed from the parameter type. Pinned by drive_sync_lift_candidates_test.ts. #296 — docs/architecture.md §6 names the cancel-read/cancel-write of an already-COMPLETED copy divergence (CANCELLED|count, following the upstream suite over definitions.py `cancel_copy`), pointing at the existing CM-3 entry in upstream-component-model-repo-findings.md. #298 — host_pump_reentrancy_probe_test.ts pins, as passing behavior, that `HostActivity.pump()`'s sync half may run `Store.tick` under a live guest activation and that `tick`'s own gates (`pendingResumptions`, serviceable settled) hold there; the issue is closed as not-a-bug with the reasoning. Closes #299. Closes #296.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-2 housekeeping from the correctness review. Details in the commit message.
driveSyncLiftno longer excludesinst.exclusiveThread(the post-CM#705 reference has no exclusion); stale citation fixed; pinned bydrive_sync_lift_candidates_test.ts.host_pump_reentrancy_probe_test.tspins the sync-half reentrance and thetickgates that make it safe.Gates: full
just gatesgreen on the union with the cancel-parity PR.Closes #299. Closes #296. Automerge armed.