Adds PR review skill and checklist for pull request evaluations#7227
Merged
Conversation
Contributor
|
Isn't this simular to #7193? |
Member
Author
|
Yes it is. @milanholemans and I crossed streams. Like we agreed, we closed his PR in favor of this one. |
milanholemans
requested changes
Jun 7, 2026
milanholemans
left a comment
milanholemans
left a comment
Contributor
There was a problem hiding this comment.
Looks promising, would like to see this in action. Made a few remarks while reviewing the skill.
milanholemans
marked this pull request as draft
June 7, 2026 20:53
waldekmastykarz
marked this pull request as ready for review
June 22, 2026 12:14
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Milan Holemans <11723921+milanholemans@users.noreply.github.com>
Co-authored-by: Milan Holemans <11723921+milanholemans@users.noreply.github.com>
- Remove obsolete PII/telemetry tracking rule (handled centrally by Zod) - Replace 'All tests must pass' with 'npm test must pass without errors' - Add Documentation Quality section (D) to SKILL.md - Add Reference Commands section pointing to example implementations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace optionSet rule with custom Zod validation (option sets obsolete) - Add test checks: command name/description not null, schema validation - Add sinon.restore() in after() rule for tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove MkDocs warning check (not applicable to Docusaurus) - Add command page sections check to documentation - Remove logger.logToStderr from SKILL.md (enforced by ESLint) - Remove telemetry mention from SKILL.md (handled centrally by Zod) - Add verbose logging requirement to SKILL.md - Clarify defaultProperties is for list commands only - Specify formatting utilities for escaping user input Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
waldekmastykarz
force-pushed
the
pr-review-skill
branch
from
July 8, 2026 07:09
c301e31 to
051d02b
Compare
ESLint already handles this validation through a custom rule, so it's redundant for the AI reviewer to check. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The 'include the marker to incorporate global options' line was a MkDocs convention. Docusaurus uses component imports instead. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 31699654-6aea-43f7-bb59-89b2e5adca0c
milanholemans
approved these changes
Jul 15, 2026
milanholemans
left a comment
milanholemans
left a comment
Contributor
There was a problem hiding this comment.
LGTM apart from a little change. Also let's not forget to update our docs checklist as well.
|
|
||
| Post inline comments and the summary as a single review submission. Always target the actual line where the issue exists. | ||
|
|
||
| **API limitation**: The GitHub API can only target lines within diff hunk ranges (changed lines + surrounding context lines). If the target line falls in a gap between hunks, do **not** post it on a nearby line. Instead, include that finding in the summary (the review body) with the file path and line number. Only use `suggestion` blocks for findings posted on the exact target line. |
Contributor
There was a problem hiding this comment.
This shouldn't be the case anymore: https://github.blog/changelog/2025-09-25-pull-request-files-changed-public-preview-now-supports-commenting-on-unchanged-lines/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.