Skip to content

Closes #2197: SDK drift: Python's SIX_DEC_SCALE in _hosted_mappers.py lacks the underscore-private naming its TypeScript counterpart and its own Python sibling use #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evgenyponomarev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Closes #2197: SDK drift: Python's SIX_DEC_SCALE in _hosted_mappers.py lacks the underscore-private naming its TypeScript counterpart and its own Python sibling use #2210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/python/pmxt/_hosted_mappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
from .errors import InvalidOrder
from .models import Balance, BuiltOrder, Order, Position, UserTrade

SIX_DEC_SCALE = 1_000_000
_SIX_DEC_SCALE = 1_000_000

_T = TypeVar("_T")


def to_6dec(amount: float | str | Decimal) -> int:
"""Convert a decimal amount to integer micro-units with no rounding."""
d = Decimal(str(amount))
scaled = d * SIX_DEC_SCALE
scaled = d * _SIX_DEC_SCALE
if scaled != scaled.to_integral_value():
raise InvalidOrder(f"amount precision exceeds 6 decimals: {amount!r}")
return int(scaled)
Expand Down
5 changes: 5 additions & 0 deletions sdks/python/tests/test_hosted_mappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ def _mapper(*names):
to_6dec = _hosted_mappers.to_6dec


def test_six_decimal_scale_is_module_private():
assert not hasattr(_hosted_mappers, "SIX_DEC_SCALE")
assert _hosted_mappers._SIX_DEC_SCALE == 1_000_000


def _iso_ms(value: str) -> int:
return int(datetime.fromisoformat(value.replace("Z", "+00:00")).timestamp() * 1000)

Expand Down