Skip to content

fix(types): correct SSAOPass height property type from boolean to number (#423) - #440

Open
Techsynx wants to merge 1 commit into
pmndrs:mainfrom
Techsynx:fix/423-ssaopass-height-type
Open

Techsynx wants to merge 1 commit into
pmndrs:mainfrom
Techsynx:fix/423-ssaopass-height-type

Conversation

@Techsynx

@Techsynx Techsynx commented Nov 3, 2026

Copy link
Copy Markdown

Summary

Fixes #423 by correcting the TypeScript type definition of SSAOPass.height from boolean to number in src/postprocessing/SSAOPass.d.ts.

Problem

In src/postprocessing/SSAOPass.js, height is initialized as a numeric dimension (defaulting to 512):

this.width = width !== undefined ? width : 512;
this.height = height !== undefined ? height : 512;

However, in src/postprocessing/SSAOPass.d.ts, height was accidentally typed as boolean (height: boolean), causing type errors for consumers referencing pass.height.

Changes

  • Updated src/postprocessing/SSAOPass.d.ts line 30 to declare height: number.

Verification

  • npm run lint (tsc --noEmit): clean with 0 type errors.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSAOPass height type error,It's number not boolean

1 participant