Add obc reading to FVCOMReader for reading restart files#37
Open
mikebedington wants to merge 3 commits into
Open
Add obc reading to FVCOMReader for reading restart files#37mikebedington wants to merge 3 commits into
mikebedington wants to merge 3 commits into
Conversation
wathen
requested changes
Jun 11, 2026
| ) | ||
| return np.ma.getdata(self._metadata_dataset.variables[var_name][:]) | ||
|
|
||
| def connected_nodes_list(obc_nodes, triangulation, obc_types=None): |
Member
There was a problem hiding this comment.
Please follow the same docstring structure as else where, for example:
def var_is_node_based(self, var_name: str) -> bool:
"""Check if a variable is node-based.
Args:
var_name (str): The name of the variable to check.
Returns:
bool: True if the variable is node-based, False if element-based.
"""
| return node_sequences, type_sequences | ||
|
|
||
|
|
||
| def _order_chain(component, adjacency): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart files contain the open boundary nodes, and its useful to be able to get a full grid object from a restart file, for example in cases where you have restart files but have somehow lost the .dat files