Fvcom reader to handle non-geographic coordinates#36
Open
mikebedington wants to merge 6 commits into
Open
Conversation
wathen
requested changes
Jun 11, 2026
| bdy_types = None | ||
|
|
||
| return MeshData(triangles, nodes, x1, x2, x3, bdy_types, open_bdy_node_lists) | ||
| return MeshData(triangles, nodes, x1, x2, x3, bdy_types, open_bdy_node_lists), coordinate_system |
Member
There was a problem hiding this comment.
Can you update the function output args to be tuple[MeshData, str]
| # Build the time index mapping for multiple files | ||
| self._build_time_index_mapping() | ||
|
|
||
| if projection is None and hasattr(self._metadata_dataset,'CoordinateProjection'): |
Member
There was a problem hiding this comment.
Guessing there is never the case where projection is None but self._metadata_dataset doesn't have CoordinateProjection as an attribute?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FVCOMReader was setup to assume geographic coordinates, so added handling of cartesian. The projection code is either passed when initiated, or found in the file in the 'CoordinateProjection' global attribute - FVCOM doesn't actually write this itself but it seems a sensible place to store it. Assumes EPSG codes of format 'EPSG:xxxx' or 'xxxx'. Now raises an error if a projection isn't provided for cartesian grids, as the reader is setup to always populate the lon/lat fields. Arguably this shouldn't be needed as idealised grids often are cartesian only, but this preserves the existing approach and a dummy code can be provided without any problems.