Add option to read depth file when loading grid from .dat files#35
Merged
Conversation
wathen
requested changes
Jun 9, 2026
wathen
left a comment
wathen
left a comment
Member
There was a problem hiding this comment.
Looks good, just two little style things really
Co-authored-by: Michael Wathen <15614849+wathen@users.noreply.github.com>
wathen
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FVCOM doesn't require you to include the depth in the {casename}_grd.dat file, but instead can use a {casename}_dep.dat file with the depth data in and have 0s in the grd file, so updating mesh_reader to be able to optionally be passed this file for the depths (and use this to overwrite any depths supplied in the grd file)