Skip to content

Fix - Table question column type edge cases - #50

Open
RomainLvr wants to merge 5 commits into
mainfrom
fix/table-question-column-types
Open

Fix - Table question column type edge cases#50
RomainLvr wants to merge 5 commits into
mainfrom
fix/table-question-column-types

Conversation

@RomainLvr

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !43740
  • Here is a brief description of what this PR does

Two related fixes for the Table question type's column configuration:

  • Custom dropdown definitions (Setup > Dropdowns) all share one database table, distinguished only by a foreign key to their definition. Table columns using a custom dropdown as their type queried that table without filtering by definition, so every column showed the combined entries of all custom dropdown definitions instead of just its own. Fixed by scoping the query with the definition's own SQL criteria.
  • The column-type dropdown offered question types (From Fields plugin) that need an extra "sub type" selector (e.g. a two-level picker) that Table's flat column-type list has no way to represent. Selecting one silently fell back to a plain text input with no indication anything was wrong. These types are now excluded from the list, using the same generic core mechanism (getSubTypes()) other plugins would use for this, no plugin-specific code added.
  • Also remove new Reservation question type from available type cause of it's specific handling

@RomainLvr
RomainLvr requested review from Rom1-B and stonebuzz August 12, 2026 14:55
@RomainLvr RomainLvr self-assigned this Aug 12, 2026
Comment thread tests/Model/QuestionType/TableQuestionTest.php
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@RomainLvr
RomainLvr requested a review from Rom1-B August 13, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants