fix(schema): require type for composable image stack in platformsh schema#264
Open
spk wants to merge 2 commits into
Open
fix(schema): require type for composable image stack in platformsh schema#264spk wants to merge 2 commits into
spk wants to merge 2 commits into
Conversation
…msh schema When using composable image stack, type is now required to be consistent with the upsun.json schema change in #258. Also switches the top-level oneOf to anyOf so that documents with both type and stack satisfy the schema correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platformsh.application.json:typeis now required when using composable imagestackoneOftoanyOfso documents with bothtypeandstackvalidate correctly (withoneOf, both branches would be satisfied simultaneously, causing a validation error)Test_validatePlatformConfigwith cases for: simple type-only app, missing required fields, stack with type (valid), and stack without type (error)Test plan
stack with typepasses validationstack without typefails validation