forked from dexidp/dex
-
Notifications
You must be signed in to change notification settings - Fork 0
Keystone connector - support for domain-scoped and system-scoped Keystone role assignments #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+262
−122
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,199 @@ | ||
| package keystone | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "log/slog" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "net/url" | ||
| "strings" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestGetRoleAssignments_IncludeNames(t *testing.T) { | ||
| var gotUserQuery, gotGroupQuery string | ||
| ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if strings.Contains(r.URL.RawQuery, "user.id=") { | ||
| gotUserQuery = r.URL.RawQuery | ||
| } | ||
| if strings.Contains(r.URL.RawQuery, "group.id=") { | ||
| gotGroupQuery = r.URL.RawQuery | ||
| } | ||
| w.WriteHeader(http.StatusOK) | ||
| _ = json.NewEncoder(w).Encode(struct { | ||
| RoleAssignments []roleAssignment `json:"role_assignments"` | ||
| }{}) | ||
| })) | ||
| defer ts.Close() | ||
|
|
||
| logger := slog.New(slog.NewTextHandler(testDiscard{}, nil)) | ||
|
|
||
| if _, err := getRoleAssignments(t.Context(), ts.Client(), ts.URL, "tok", getRoleAssignmentsOptions{userID: "u1"}, logger); err != nil { | ||
| t.Fatalf("getRoleAssignments (userID) error: %v", err) | ||
| } | ||
| if _, err := getRoleAssignments(t.Context(), ts.Client(), ts.URL, "tok", getRoleAssignmentsOptions{groupID: "g1"}, logger); err != nil { | ||
| t.Fatalf("getRoleAssignments (groupID) error: %v", err) | ||
| } | ||
|
|
||
| unescapedUserQuery, err := url.QueryUnescape(gotUserQuery) | ||
| if err != nil { | ||
| t.Fatalf("failed to unescape user query: %v", err) | ||
| } | ||
| if !strings.Contains(unescapedUserQuery, "include_names") { | ||
| t.Fatalf("expected include_names in user.id request, got query: %q", gotUserQuery) | ||
| } | ||
| unescapedGroupQuery, err := url.QueryUnescape(gotGroupQuery) | ||
| if err != nil { | ||
| t.Fatalf("failed to unescape group query: %v", err) | ||
| } | ||
| if !strings.Contains(unescapedGroupQuery, "include_names") { | ||
| t.Fatalf("expected include_names in group.id request, got query: %q", gotGroupQuery) | ||
| } | ||
| } | ||
|
|
||
| // multiScopeHandler serves the minimal set of Keystone endpoints | ||
| // getAllGroupsForUser needs, returning one project-scoped, one | ||
| // domain-scoped, and one system-scoped role assignment for the same user. | ||
| func multiScopeHandler(t *testing.T, projectDomainName string) http.HandlerFunc { | ||
| t.Helper() | ||
| return func(w http.ResponseWriter, r *http.Request) { | ||
| switch { | ||
| case strings.HasSuffix(r.URL.Path, "/v3/groups"): | ||
| w.WriteHeader(http.StatusOK) | ||
| _ = json.NewEncoder(w).Encode(groupsResponse{}) | ||
| return | ||
| case strings.Contains(r.URL.Path, "/v3/users/") && strings.HasSuffix(r.URL.Path, "/groups"): | ||
| w.WriteHeader(http.StatusOK) | ||
| _ = json.NewEncoder(w).Encode(groupsResponse{}) | ||
| return | ||
| case strings.HasSuffix(r.URL.Path, "/v3/role_assignments"): | ||
| body := `{ | ||
| "role_assignments": [ | ||
| { | ||
| "scope": {"project": {"id": "proj-1", "name": "My_Project", "domain": {"id": "dom-1", "name": "` + projectDomainName + `"}}}, | ||
| "user": {"id": "u1"}, | ||
| "role": {"id": "role-admin", "name": "admin"} | ||
| }, | ||
| { | ||
| "scope": {"domain": {"id": "dom-2", "name": "Customer_Domain"}, "OS-INHERIT:inherited_to": "projects"}, | ||
| "user": {"id": "u1"}, | ||
| "role": {"id": "role-cda", "name": "customer_domain_admin"} | ||
| }, | ||
| { | ||
| "scope": {"system": {"all": true}}, | ||
| "user": {"id": "u1"}, | ||
| "role": {"id": "role-pa", "name": "platform_admin"} | ||
| } | ||
| ] | ||
| }` | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte(body)) | ||
| return | ||
| default: | ||
| w.WriteHeader(http.StatusNotFound) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestGetAllGroupsForUser_MultiScopeDispatch(t *testing.T) { | ||
| ts := httptest.NewServer(multiScopeHandler(t, "Cust_Domain")) | ||
| defer ts.Close() | ||
|
|
||
| logger := slog.New(slog.NewTextHandler(testDiscard{}, nil)) | ||
| info := &tokenInfo{User: userKeystone{ID: "u1", Name: "user1"}} | ||
|
|
||
| groups, err := getAllGroupsForUser(t.Context(), ts.Client(), ts.URL, "tok", "cust", "login-domain", info, logger) | ||
| if err != nil { | ||
| t.Fatalf("getAllGroupsForUser error: %v", err) | ||
| } | ||
|
|
||
| want := map[string]bool{ | ||
| "cust-cust-domain-my-project-admin": true, // 4-part project group | ||
| "cust-customer-domain-customer_domain_admin": true, // 3-part domain group | ||
| "cust-platform_admin": true, // 2-part system group | ||
| } | ||
| if len(groups) != len(want) { | ||
| t.Fatalf("unexpected groups: got %v, want keys %v", groups, want) | ||
| } | ||
| for _, g := range groups { | ||
| if !want[g] { | ||
| t.Errorf("unexpected group %q in result %v", g, groups) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestGetAllGroupsForUser_ProjectOnlyUsesRowDomainNotConfig(t *testing.T) { | ||
| ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| switch { | ||
| case strings.HasSuffix(r.URL.Path, "/v3/groups"): | ||
| w.WriteHeader(http.StatusOK) | ||
| _ = json.NewEncoder(w).Encode(groupsResponse{}) | ||
| return | ||
| case strings.Contains(r.URL.Path, "/v3/users/") && strings.HasSuffix(r.URL.Path, "/groups"): | ||
| w.WriteHeader(http.StatusOK) | ||
| _ = json.NewEncoder(w).Encode(groupsResponse{}) | ||
| return | ||
| case strings.HasSuffix(r.URL.Path, "/v3/role_assignments"): | ||
| body := `{ | ||
| "role_assignments": [ | ||
| { | ||
| "scope": {"project": {"id": "proj-1", "name": "myproject", "domain": {"id": "dom-1", "name": "RowDomain"}}}, | ||
| "user": {"id": "u1"}, | ||
| "role": {"id": "role-admin", "name": "admin"} | ||
| } | ||
| ] | ||
| }` | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte(body)) | ||
| return | ||
| default: | ||
| w.WriteHeader(http.StatusNotFound) | ||
| } | ||
| })) | ||
| defer ts.Close() | ||
|
|
||
| logger := slog.New(slog.NewTextHandler(testDiscard{}, nil)) | ||
| info := &tokenInfo{User: userKeystone{ID: "u1", Name: "user1"}} | ||
|
|
||
| // Pass a DIFFERENT domainID (the connector's configured login domain) | ||
| // than the row's own scope.project.domain.name, to prove the row's | ||
| // data wins, not the config value. | ||
| groups, err := getAllGroupsForUser(t.Context(), ts.Client(), ts.URL, "tok", "cust", "login-domain", info, logger) | ||
| if err != nil { | ||
| t.Fatalf("getAllGroupsForUser error: %v", err) | ||
| } | ||
|
|
||
| want := "cust-rowdomain-myproject-admin" | ||
| if len(groups) != 1 || groups[0] != want { | ||
| t.Fatalf("unexpected groups: got %v, want [%q]", groups, want) | ||
| } | ||
| } | ||
|
|
||
| func TestGenerateGroupName(t *testing.T) { | ||
| p := projectScope{Name: "My_Project", Domain: namedIdentifier{Name: "My_Domain"}} | ||
| role := namedIdentifier{Name: "_member_"} | ||
| got := generateGroupName(p, role, "cust") | ||
| want := "cust-my-domain-my-project-member" | ||
| if got != want { | ||
| t.Fatalf("got %q, want %q", got, want) | ||
| } | ||
| } | ||
|
|
||
| func TestGenerateDomainGroupName(t *testing.T) { | ||
| domain := namedIdentifier{Name: "Customer_Domain"} | ||
| role := namedIdentifier{Name: "customer_domain_admin"} | ||
| got := generateDomainGroupName(domain, role, "cust") | ||
| want := "cust-customer-domain-customer_domain_admin" | ||
| if got != want { | ||
| t.Fatalf("got %q, want %q", got, want) | ||
| } | ||
| } | ||
|
|
||
| func TestGenerateSystemGroupName(t *testing.T) { | ||
| role := namedIdentifier{Name: "_member_"} | ||
| got := generateSystemGroupName(role, "cust") | ||
| want := "cust-member" | ||
| if got != want { | ||
| t.Fatalf("got %q, want %q", got, want) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.