Fix unbound RATE_MB_HR under set -u; drop dead code in helper scripts#68
Merged
Conversation
- check-cdc-status.sh: initialize RATE_MB_HR/RATE_GB_HR alongside the other rate vars so the total-gap ETA branch does not abort with an unbound-variable error under set -u when no apply rate has been computed yet. - preflight-check.sh: remove unused TOTAL. - verify-migration.sh: remove never-called q_verbose().
DmitriiAn
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes surfaced while running the scripts and via shellcheck.
RATE_MB_HR/RATE_GB_HRare only assigned inside the rate-calc block, which is skipped when no apply rate can be computed yet (e.g. <60s elapsed, no applied bytes). The later total-gap ETA branch readsRATE_MB_HRunderset -u, so the script aborted withRATE_MB_HR: unbound variable. Initialize both to""with the other rate vars.TOTAL(computed but never printed; the summary reports pass/warn/fail separately).q_verbose().Verification:
bash -npasses on all three;shellcheckclean of the targeted findings (remaining items are known-benign — source-follow on~/.env,lsin timestamped dirs, tilde in display strings).