Add external keyspace creation - #1428
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
no-itsbackpack
marked this pull request as ready for review
September 18, 2026 17:52
eileencodes
approved these changes
Sep 18, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c13403a. Configure here.
enriikke
approved these changes
Sep 18, 2026
There was a problem hiding this comment.
Risk: medium. Left a non-blocking comment and did not approve because Cursor Bugbot was present but completed as skipped, so that required review signal did not finish successfully. Human review is needed; no reviewers were assigned.
Sent by Cursor Approval Agent: cli-reviewer
The dry-run only failed on connection errors, so a source with per-table lint errors was reported as compatible. Type lint_errors so the response carries them and list them in human output. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace pscale workflow as the Vitess table-move path in the embedded agent guide. Document keyspace create-external and branch vtctld move-tables, including next_steps and approval gates. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep move-tables as the preferred path without telling agents the old command is forbidden. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
pscale keyspace create-externalwith datasource linting, optional cluster sizing, and wait support.pscale size cluster list --externallists only valid external keyspace sizes, and cluster-size completion uses the same filtered list.