[Issue #1279] Replace C++ metadata serialization with FlatBuffers - #1390
Open
whzruc wants to merge 1 commit into
Open
[Issue #1279] Replace C++ metadata serialization with FlatBuffers#1390whzruc wants to merge 1 commit into
whzruc wants to merge 1 commit into
Conversation
whzruc
force-pushed
the
rebuild/cpp-flatbuffers-serialization
branch
2 times, most recently
from
August 27, 2026 09:47
adaa077 to
ce3304a
Compare
Collaborator
Author
|
Null handling was tightened during round-trip validation:
Validated with the 4 integer writer tests, all 7 PixelsWriter tests, and a CLI-to-DuckDB round trip producing |
…fers Replace the C++ Protobuf metadata path with FlatBuffers while keeping the Java and gRPC Protobuf definitions unchanged. - add the shared Pixels metadata schema under flatbuffers/ and vendor the FlatBuffers toolchain - generate and link FlatBuffers sources from the C++ build - migrate reader, writer, footer, statistics, CLI, and DuckDB integration paths - fix integer decoding, 64-bit RLE handling, async reads, and CLI error handling - extend writer and CLI round-trip coverage Tests: - make -j - IntegerWriterTest (4 tests) - PixelsWriterTest --gtest_also_run_disabled_tests (7 tests) - pixels-cli LOAD followed by DuckDB pixels_scan round trip
whzruc
force-pushed
the
rebuild/cpp-flatbuffers-serialization
branch
from
August 27, 2026 11:56
ce3304a to
9e0c2b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1279.
This PR supersedes the closed and unmerged #1282. It rebuilds the FlatBuffers migration on the latest
masterand includes the correctness and integration fixes found during validation.Summary
flatbuffers/pixels.fbsThe existing
proto/*.protodefinitions remain unchanged for Java and gRPC users. This change only replaces the C++ Pixels file-metadata serialization path.Validation
make -jIntegerWriterTest: 4/4 passedPixelsWriterTest --gtest_also_run_disabled_tests: 7/7 passedpixels-cli LOADgenerated a FlatBuffers-based.pxlfilepixels_scansuccessfully read the generated file and returned the expected 3-row aggregate and valuesCompatibility note
Files produced by this C++ implementation use FlatBuffers metadata and therefore require the corresponding FlatBuffers-aware C++ reader.