feat(mobile): prototype radial model picker - #5238
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 76320a9. Configure here.
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. This PR introduces a new feature (~1000 lines) with multiple unresolved review comments identifying bugs in palette state management and gesture handling. These substantive issues warrant human review before merging. You can customize Macroscope's approvability policy. Learn more. |
76320a9 to
893f480
Compare
|
Review update for
Validation:
All three inline review threads have been answered and resolved. This remains an experimental draft PoC, not a merge-ready feature. |

Below written by sol, but hope you like the concept, if there's anything you want me to change, I'm happy to point my tokens at it :)
Important
Experimental PoC — not ready to merge. This draft is open so maintainers can inspect, run, and discuss the interaction before we commit to production scope.
What Changed
Enable the experiment when starting Metro with
EXPO_PUBLIC_MODEL_PICKER_PROTOTYPE=1.Why
This explores whether a thumb-driven marking menu can make frequent model and reasoning changes faster without competing with iOS or Android edge gestures. It is intentionally an experimental PoC: palette membership is session-local and the existing picker remains unchanged when the flag is absent.
Not Production-Ready
Pressable; a production pass should evaluate a dedicated gesture recognizer and its cancellation semantics.UI Changes
Before / after
Interaction
t3-model-picker-pr-demo-compressed.mp4
Supporting states
Verification
./node_modules/.bin/vp test run apps/mobile/src/features/threads/model-picker-prototype/modelPickerPrototypeState.test.ts./apps/mobile/node_modules/.bin/tsc -p apps/mobile/tsconfig.json --noEmit./node_modules/.bin/vp fmt --check <changed files>git diff --checkChecklist
Built with GPT-5.6 Sol via Codex in T3 Code.