Refactor preview port scanner Effect patterns#3082
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Context.Referencefor the preview port scanner platform, so tests can providewin32through a layer instead of mutatingprocess.platform.nullfallbacks withEffect.option/Optionhandling and switched timeout constants toDuration.secondsvalues.@effect/vitestassertions in the touched coverage.Why
This keeps the preview port scanner more idiomatic and testable with Effect: runtime platform is now injectable via context, expected command failures are modeled as optional fallbacks, and tests no longer monkey-patch global Node state.
UI Changes
None.
Checklist
Verification:
pnpm --filter t3 exec vp test run src/preview/PortScanner.test.ts(17 tests passed)pnpm exec vp run typecheckpnpm exec vp check(0 errors, 11 existing warnings)Note
Refactor
PortScannerto inject platform context and use Effect-native patternsCurrentPlatformas aContext.Referencein PortScanner.ts, replacing direct reads ofprocess.platformso the Windows code path can be injected in tests without monkey-patching.null-based fallback control flow withEffect.optionandOption.isSomechecks inPortDiscovery.make.Duration-based constants (LSOF_TIMEOUT,WINDOWS_LISTENER_TIMEOUT).expectto@effect/vitestassert APIs, updates the mockProcessRunnerto return a typedProcessSpawnError, and suppliesCurrentPlatformvia the test layer.Macroscope summarized ba5fd84.