i18n(ja): add missing ni particle for clarity in diagnostics N-fold wording - #23821
i18n(ja): add missing ni particle for clarity in diagnostics N-fold wording#23821yahonda wants to merge 1 commit into
Conversation
…ording
QPS and P999 query latency N-fold change sentences lacked the ni
particle used by sibling sentences in the same list, making the
ratio reading ("became N times the original") less explicit. Verified
against the actual screenshot numbers referenced in the doc, which
confirm a straightforward new/old ratio interpretation.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change revises two Japanese diagnostic metric descriptions. It inserts the particle "に" after "倍" without changing the documented metric meaning or behavior. ChangesDiagnostic documentation wording
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This documentation-only wording update clarifies two Japanese metric descriptions without changing product behavior or metric interpretation. It is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
In
dashboard/dashboard-diagnostics-usage.md, two "N-fold" sentences (QPS decreased 0.93x, P999 query latency increased 1.54x) lacked theにparticle that sibling sentences in the same bullet list already use (e.g.2.48 倍に増加しました,7.61 倍に増加しました). This PR addsにto both sentences for consistency and to make the ratio reading ("became N times the original value") explicit.Verified against the actual numbers in the referenced screenshot (
/media/dashboard/dashboard-diagnostics-usage2.png):tidb_qpsshows34927.00 / 37658.00 ≈ 0.93, confirming this is a straightforward new/old ratio, not a subtractive change.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit