Skip to content

i18n(ja): add missing ni particle for clarity in diagnostics N-fold wording - #23821

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-diagnostics-duration-ni
Open

i18n(ja): add missing ni particle for clarity in diagnostics N-fold wording#23821
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-diagnostics-duration-ni

Conversation

@yahonda

@yahonda yahonda commented Sep 10, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

In dashboard/dashboard-diagnostics-usage.md, two "N-fold" sentences (QPS decreased 0.93x, P999 query latency increased 1.54x) lacked the particle that sibling sentences in the same bullet list already use (e.g. 2.48 倍に増加しました, 7.61 倍に増加しました). This PR adds to both sentences for consistency and to make the ratio reading ("became N times the original value") explicit.

Verified against the actual numbers in the referenced screenshot (/media/dashboard/dashboard-diagnostics-usage2.png): tidb_qps shows 34927.00 / 37658.00 ≈ 0.93, confirming this is a straightforward new/old ratio, not a subtractive change.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Improved the Japanese wording of diagnostic report metric descriptions for clarity and grammatical correctness.

…ording

QPS and P999 query latency N-fold change sentences lacked the ni
particle used by sibling sentences in the same list, making the
ratio reading ("became N times the original") less explicit. Verified
against the actual screenshot numbers referenced in the doc, which
confirm a straightforward new/old ratio interpretation.
@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f3c09203-549c-4813-8a9e-49885c99f0f5

📥 Commits

Reviewing files that changed from the base of the PR and between f246bc4 and e2e993e.

📒 Files selected for processing (1)
  • dashboard/dashboard-diagnostics-usage.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change revises two Japanese diagnostic metric descriptions. It inserts the particle "に" after "倍" without changing the documented metric meaning or behavior.

Changes

Diagnostic documentation wording

Layer / File(s) Summary
Metric description wording
dashboard/dashboard-diagnostics-usage.md
The tidb_qps and tidb_query_duration descriptions use revised Japanese grammar.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e2e99

This documentation-only wording update clarifies two Japanese metric descriptions without changing product behavior or metric interpretation. It is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the two wording changes, identifies the affected file and version branch, documents validation, and includes AI involvement and scope checklists. It is complete enough for rev…
Title check ✅ Passed The title clearly identifies the Japanese localization change and the missing particle in the diagnostics N-fold wording.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants