i18n(ja): unify partition-type and pruning-mode naming - #23810
Conversation
ti-chi-bot
Bot
added
the
missing-translation-status
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/L
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis documentation-only change standardizes Japanese partitioning terminology across reference pages, guides, examples, and release notes. Technical content, links, measurements, and support values remain unchanged. ChangesPartitioning terminology standardization
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Merge Risk: 🔵 Low · up to The partitioning documentation contains a few inconsistent or incomplete user-facing descriptions. These localized wording fixes should be addressed to complete the terminology standardization safely. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yahonda
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 9744686b-a284-44c8-9f3e-64beda0cb0af
📒 Files selected for processing (26)
basic-features.mdbest-practices/tidb-partitioned-tables-best-practices.mdglobal-indexes.mdpartition-pruning.mdpartitioned-table.mdreleases/release-3.0-beta.mdreleases/release-3.0-ga.mdreleases/release-3.0.0-rc.2.mdreleases/release-3.0.15.mdreleases/release-3.0.5.mdreleases/release-3.0.8.mdreleases/release-4.0-ga.mdreleases/release-4.0.12.mdreleases/release-4.0.2.mdreleases/release-4.0.5.mdreleases/release-5.1.4.mdreleases/release-5.1.5.mdreleases/release-6.0.0-dmr.mdreleases/release-6.1.6.mdreleases/release-6.3.0.mdreleases/release-6.5.2.mdreleases/release-6.5.8.mdreleases/release-7.1.0.mdreleases/release-7.1.1.mdreleases/release-7.1.4.mdsql-statements/sql-statement-split-region.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
yahonda
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
partitioned-table.md (1)
407-407: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winReplace the remaining English partitioning term.
Line [407] still says
リスト COLUMNSパーティションテーブル, while this section now usesリスト列パーティションテーブル. Replace the sentence with the wording below.Proposed wording
デフォルトのパーティションのないリストまたはリスト列パーティションテーブルの場合、
INSERT文を使用して挿入する値は、テーブルのPARTITION ... VALUES IN (...)句で定義されている値セットと一致する必要があります。挿入する値がどのパーティションの値セットとも一致しない場合、ステートメントは失敗し、次の例に示すようにエラーが返されます。As per path instructions, this Markdown issue uses proposed wording because Line [407] is outside the changed range.
Source: Path instructions
releases/release-3.0-beta.md (1)
78-78: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUse
レンジパーティショニングat Line 78.Line 78 still uses
レンジパーティション, while the same release note andpartitioned-table.mduseレンジパーティショニング. Replace the changed line with the exact text below.Apply this replacement
- - レンジパーティションをサポート[`#8011`](https://github.com/pingcap/tidb/pull/8011) + - レンジパーティショニングをサポート[`#8011`](https://github.com/pingcap/tidb/pull/8011)As per path instructions, Markdown issues with a contiguous safe fix must include an exact committable replacement block.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 21574249-fd79-4a33-ba8d-87da07c2592a
📒 Files selected for processing (12)
basic-features.mdbest-practices/tidb-partitioned-tables-best-practices.mdmysql-compatibility.mdpartitioned-table.mdreleases/release-3.0-beta.mdreleases/release-5.0.0.mdreleases/release-6.1.0.mdreleases/release-6.4.0.mdreleases/release-7.0.0.mdreleases/release-7.3.0.mdreleases/release-8.4.0.mdsystem-variables.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
qiancai
added
translation/no-need
yahonda
changed the title
ee06e74 to
2c9aa26
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: d5503dde-5b8f-437d-b98d-ffe8b0871c9e
📒 Files selected for processing (19)
basic-features.mdbest-practices/tidb-partitioned-tables-best-practices.mdglobal-indexes.mdmysql-compatibility.mdpartitioned-table.mdreleases/release-3.0.0-rc.2.mdreleases/release-5.0.0.mdreleases/release-6.1.0.mdreleases/release-6.3.0.mdreleases/release-7.1.0.mdreleases/release-7.1.1.mdreleases/release-7.3.0.mdreleases/release-8.4.0.mdreleases/release-8.5.0.mdreleases/release-8.5.1.mdstatistics.mdsystem-variables.mdtiflash-upgrade-guide.mdtiflash/use-tiflash-mpp-mode.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
Unify the "Range" partition-type name to the katakana form (matching Hash/Key/List, which have no competing kanji form) across partitioned-table.md and its sibling docs/release notes -- 84 sites across 26 files, each verified against release-8.5. releases/release-4.0.9.md is intentionally excluded: its one "range split" mention refers to a TiDB Lightning data-ingestion range split, not SQL RANGE partitioning. This does not touch the separate, still-open "partitioning vs division" suffix inconsistency or the untranslated "List" partition type name -- those are tracked as follow-up sweeps.
The "List" and "List COLUMNS" partition-type names were left as literal untranslated English in ~20 sites across 8 files, while body prose elsewhere already used the katakana form consistently. Translate List -> リスト and List COLUMNS -> リスト列, matching how "Range COLUMNS" is already translated (COLUMNS -> 列) and the established katakana convention for the other partition types (Hash/Key/Range). Also fixes a stray "ショニング" MT-scramble fragment in partitioned-table.md's intro sentence, and reconstructs releases/release-6.1.0.md's "User documents" line, which had dropped a word and reversed the link order relative to EN.
Unify the noun "partitioning" suffix for Range/Hash/Key/List partition types to the katakana form (パーティショニング), which was already the dominant form (57 vs 16 sites), matching EN's consistent "partitioning" wording. 13 sites across 6 files. Deliberately does not touch the verb-participle construction "X分割 された" (e.g. global-indexes.md's "range partitioned by PK" table labels) -- that is a different, correct grammatical use of 分割 as a verb stem, not the noun compound this sweep targets.
…n docs
global-indexes.md: two benchmark table rows had "range"/"hash" word
order scrambled relative to their correct sibling rows (e.g. "PK de
partition-ized clustered-table range" instead of "clustered table
range-partitioned by PK") -- reconstructed to match EN and the
adjacent, already-correct rows.
releases/release-6.3.0.md, releases/release-7.1.0.md: "Range COLUMNS"
and "Range INTERVAL partitioning" left as literal untranslated English
in a few sites missed by the corpus-wide sweep (the compound had
COLUMNS/INTERVAL wedged between レンジ and パーティショニング, which
the sweep's substring rules did not match).
partitioned-table.md: dropped は particle after `NULL` ("NULL is not
an integer").
Unify 動的剪定/静的剪定 to 動的プルーニング/静的プルーニング, matching partitioned-table.md's own heading and the already-dominant katakana form (43 vs 12 sites before this fix). Confirmed a same-paragraph self-contradiction in statistics.md (動的剪定モード link text next to 動的プルーニングモード body prose for the same referent). 16 sites across 8 files, each verified against release-8.5.
Reverses the earlier choice to translate COLUMNS -> 列: Japanese has no
grammatical number, so 列 loses the "multiple columns" nuance that
COLUMNS conveys in EN ("Range/List COLUMNS partitioning" supports
partitioning by more than one column, unlike plain Range/List
partitioning). Keeping COLUMNS in English preserves that distinction,
matching the earlier choice to keep INTERVAL in English for the same
reason (a qualifier word on the base Range/Hash/Key/List type name).
38 sites across 9 files.
An independent review of this PR's diff found a handful of sites this sweep's substring-replace rules missed, all sharing the same pattern: an English qualifier word (COLUMNS/INTERVAL) wedged between the base partition-type word and パーティション caused the exact-substring match to skip the site. - releases/release-6.3.0.md: 範囲COLUMNS -> レンジCOLUMNS (2 sites) - partitioned-table.md: heading using the old suffix -> unified to match every other mention of this exact concept in the same file - best-practices/tidb-partitioned-tables-best-practices.md: literal untranslated English partition-type name, translated - releases/release-8.5.1.md: literal untranslated English partition-type name, translated (found via a final corpus-wide sweep after fixing the above, not part of the original review)
…abbit Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…CodeRabbit Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
d40006e to
8d8a907
Compare
Hash/Range COLUMNS partitioning named as パーティション instead of the standardized パーティショニング suffix used elsewhere in this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
partitioned-table.md (1)
407-407: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUse the standardized
リストCOLUMNSspelling.Line [407] still uses
リスト COLUMNSパーティションテーブル, while the same section usesリストCOLUMNSパーティションテーブル. This leaves one visible terminology mismatch.Proposed wording
デフォルトのパーティションのないリストまたはリストCOLUMNSパーティションテーブルの場合、 `INSERT`文を使用して挿入する値は、テーブルの`PARTITION ... VALUES IN (...)`句で定義されている値セットと一致する必要があります。挿入する値がどのパーティションの値セットとも一致しない場合、ステートメントは失敗し、次の例に示すようにエラーが返されます。As per path instructions: use a regular review comment when the fix is outside the diff; provide the exact replacement as proposed wording.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 284917e6-cfcf-422f-b756-19fac1f580a3
📒 Files selected for processing (39)
basic-features.mdbest-practices/tidb-partitioned-tables-best-practices.mdglobal-indexes.mdmysql-compatibility.mdpartition-pruning.mdpartitioned-table.mdreleases/release-3.0-beta.mdreleases/release-3.0-ga.mdreleases/release-3.0.0-rc.2.mdreleases/release-3.0.15.mdreleases/release-3.0.5.mdreleases/release-3.0.8.mdreleases/release-4.0-ga.mdreleases/release-4.0.12.mdreleases/release-4.0.2.mdreleases/release-4.0.5.mdreleases/release-5.0.0.mdreleases/release-5.1.4.mdreleases/release-5.1.5.mdreleases/release-6.0.0-dmr.mdreleases/release-6.1.0.mdreleases/release-6.1.6.mdreleases/release-6.3.0.mdreleases/release-6.4.0.mdreleases/release-6.5.2.mdreleases/release-6.5.8.mdreleases/release-7.0.0.mdreleases/release-7.1.0.mdreleases/release-7.1.1.mdreleases/release-7.1.4.mdreleases/release-7.3.0.mdreleases/release-8.4.0.mdreleases/release-8.5.0.mdreleases/release-8.5.1.mdsql-statements/sql-statement-split-region.mdstatistics.mdsystem-variables.mdtiflash-upgrade-guide.mdtiflash/use-tiflash-mpp-mode.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
- partitioned-table.md: add the missing predicate (データ型を使用できます) to the Range COLUMNS partition column description - system-variables.md: remove the stray leftover パーティション before the dynamic pruning mode link
2 participants
What is changed, added or deleted? (Required)
A stacked sweep on "partitioning type" and related notation issues found while auditing
partitioned-table.mdagainst EN:Range -> レンジ (katakana): matches Hash/Key/List, none of which have a competing kanji form (previously 範囲/レンジ split, 51 vs 5). 84+ sites across 26+ files verified against
release-8.5.releases/release-4.0.9.md's unrelated "range split" (TiDB Lightning ingestion) correctly excluded.List -> リスト (translate the untranslated English name): "List"/"List COLUMNS" left as literal English in ~20 sites/8 files despite リスト being dominant elsewhere.
分割 -> パーティショニング (unify the "partitioning" suffix): パーティショニング was already dominant (57 vs 16); unified, excluding the verb-participle "X分割された" construction (e.g.
global-indexes.md's "range partitioned by PK" table labels), which is a different, correct grammatical use of 分割.COLUMNS kept in English for "Range/List COLUMNS partitioning" (reversing an initial translate-to-列 pass): Japanese has no grammatical number, so 列 loses the "supports multiple columns" nuance COLUMNS conveys in EN. Keeping COLUMNS in English preserves that distinction, matching INTERVAL (also kept in English) as a qualifier on the base Range/Hash/Key/List name.
動的/静的剪定 -> 動的/静的プルーニング: unify to the already-dominant katakana form (43 vs 12), matching
partitioned-table.md's own heading. Confirmed a same-paragraph self-contradiction instatistics.md.Assorted defects found during review: a stray "ショニング" MT-scramble fragment in
partitioned-table.md's intro; a scrambled/reordered "User documents" line inreleases/release-6.1.0.md; two word-order-scrambled benchmark table rows inglobal-indexes.md("PK de partition-ized clustered-table range" instead of "clustered table range-partitioned by PK"); a dropped は particle after`NULL`inpartitioned-table.md; missing spaces around INTERVAL in two release notes.パーティションプルーニング(partition pruning) itself was checked and found fully consistent (109/109 sites) -- not part of this PR.パーティション化(the verb/participle "partitioned") was checked and confirmed to be a different grammatical category from パーティショニング (the noun), not 表記揺れ -- also not touched.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit