Skip to content

performance-tuning-practices: fix Scenario 2 CPU utilization value - #23791

Open
yahonda wants to merge 1 commit into
pingcap:masterfrom
yahonda:fix-scenario5-cpu-utilization-value
Open

performance-tuning-practices: fix Scenario 2 CPU utilization value#23791
yahonda wants to merge 1 commit into
pingcap:masterfrom
yahonda:fix-scenario5-cpu-utilization-value

Conversation

@yahonda

@yahonda yahonda commented Sep 9, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes a data inconsistency in the Summary section: comparing Scenario 5 with Scenario 2, the bullet stated the average TiDB CPU utilization "drops from 936% to 577%," but 936% is actually Scenario 3's value (per line ~174: "The TiDB average CPU utilization increases from 874% to 936%"), not Scenario 2's. Scenario 2's actual value is 874% (per line ~117: "the average TiDB CPU utilization drops from 925% to 874%"). This looks like a copy-paste error from the adjacent bullet ("Comparing Scenario 7 with Scenario 3 ... drops from 936% to 478%"), which correctly uses 936% since it's comparing against Scenario 3.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • Related code change PR links (if applicable):
  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 63503d38-9077-4b74-be38-85ff27e65f50

📥 Commits

Reviewing files that changed from the base of the PR and between 1b0fd93 and dd617cf.

📒 Files selected for processing (1)
  • performance-tuning-practices.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant