Skip to content

Fix Raft ready/apply jargon mistranslated as generic Japanese words - #23785

Closed
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-raft-ready-apply-jargon
Closed

Fix Raft ready/apply jargon mistranslated as generic Japanese words#23785
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-raft-ready-apply-jargon

Conversation

@yahonda

@yahonda yahonda commented Sep 9, 2026

Copy link
Copy Markdown
Member

What is changed, added, or deleted? (Required)

Fixes the Raft-internal jargon terms ready (the etcd/raft Ready struct/batch of entries-messages-snapshot to process) and apply (applying a committed log entry/proposal to the state machine) that were mistranslated using their generic-dictionary sense (準備完了 "preparation complete" and 適用 "apply/use a setting") instead of the specific Raft jargon sense. This is the same defect class found and fixed in PR #23781 (grafana-tikv-dashboard.md); this PR extends the same fix to the rest of the corpus. Verified via docs-cn, which keeps both terms as literal, untranslated English throughout the equivalent sections.

Files changed:

  • alert-rules.md: 3 alert descriptions (apply log duration, apply thread, process ready duration).
  • deploy-monitoring-services.md: 1 monitoring bullet (Raft processes the ready state).
  • dashboard/dashboard-monitoring.md and grafana-performance-overview-dashboard.md: restored literal English Grafana/TiDB Dashboard panel headings and metric labels across the whole file (same panel-name defect class as PR i18n(ja): restore literal English Grafana panel names in dashboard docs #23763/i18n(ja): restore literal English Grafana panel names in TiKV dashboard doc #23781, not yet applied to these two files), plus fixed the apply-loop/apply-log body descriptions.
  • performance-tuning-methods.md: fixed a scrambled Apply Log Duration table row (kept consistent with the file's own already-established 適用ログ期間 heading wording, checked against docs-cn); left the file's other 適用 occurrences (apply a formula/algorithm) untouched since those are generic usage.
  • tidb-cloud/built-in-monitoring.md: 3 metric-table description cells (apply duration, apply log duration).
  • tikv-configuration-file.md and dynamic-config.md: config-item descriptions for max-apply-unpersisted-log-limit, apply-pool-size, apply-yield-write-size, min-pending-apply-region-count, and enable-async-apply-prewrite.
  • tune-tikv-thread-performance.md: 1 thread-pool description (Apply thread), matching the file's own existing capitalized usage.
  • troubleshoot-stale-read.md: 6 sites describing safe-ts/resolved-ts and apply index semantics.
  • latency-breakdown.md: 2 sites (async-write Apply phase, apply duration from RocksDB perf context).
  • releases/release-7.1.6.md, release-7.5.4.md, release-7.5.5.md, release-7.5.6.md, release-7.5.7.md: the recurring "waiting for the log to be applied" TiKV-restart release note.
  • releases/release-8.2.0.md: 3 sites, including 早期応募 ("early job application"), a homonym mistranslation of the "early apply" feature name, confirmed against docs-cn's 提前 apply.
  • tidb-cloud/v8.5-performance-highlights.md: 1 site (leader applying Raft logs early).

Left untouched after per-site verification against the real EN source: release-7.5.4.md's tidb_redact_log line, release-8.2.0.md's privilege-control line, release-8.5.8.md's flow-control/BR-log-restore/TiCDC-DML-apply lines (a different, TiCDC/BR redo-log-apply concept, not TiKV's raftstore Apply), and several generic apply-a-formula/algorithm/constraint sites in tikv-configuration-file.md and performance-tuning-methods.md — all of these use "apply"/"ready" in the ordinary generic-English sense, not the Raft-specific jargon sense.

Which TiDB version(s) do your changes apply to? (Required)

  • v8.5 (TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

The etcd/raft internal terms 'ready' (the Ready struct/batch of
entries-messages-snapshot to process) and 'apply' (applying a
committed log entry/proposal to the state machine) were mistranslated
using their generic-dictionary sense (準備完了 "preparation complete"
and 適用 "apply/use a setting") instead of the specific Raft jargon
sense, following the same defect class found and fixed in PR pingcap#23781
(grafana-tikv-dashboard.md). Confirmed via docs-cn, which keeps both
terms as literal, untranslated English throughout the equivalent
sections. Every site below was checked against the real EN sentence
before changing it; matching generic "apply a setting/formula/patch"
and "status is ready" usages elsewhere in these same files were left
untouched.

- alert-rules.md: 3 alert descriptions (apply log duration, apply
  thread, process ready duration).
- deploy-monitoring-services.md: 1 monitoring bullet (Raft processes
  the ready state).
- dashboard/dashboard-monitoring.md and
  grafana-performance-overview-dashboard.md: restored literal English
  Grafana/TiDB Dashboard panel headings and metric labels across the
  whole file (same panel-name defect class as PR pingcap#23763/pingcap#23781, not
  yet applied to these two files), plus fixed the apply-loop/apply-log
  body descriptions.
- performance-tuning-methods.md: fixed a scrambled Apply Log Duration
  table row (kept consistent with the file's own already-established
  適用ログ期間 heading wording after checking docs-cn); left the
  file's other 適用 occurrences (apply a formula/algorithm) untouched.
- tidb-cloud/built-in-monitoring.md: 3 metric-table description cells
  (apply duration, apply log duration).
- tikv-configuration-file.md and dynamic-config.md: config-item
  descriptions for max-apply-unpersisted-log-limit, apply-pool-size,
  apply-yield-write-size, min-pending-apply-region-count, and
  enable-async-apply-prewrite.
- tune-tikv-thread-performance.md: 1 thread-pool description (Apply
  thread), matching the file's own existing capitalized usage.
- troubleshoot-stale-read.md: 6 sites describing safe-ts/resolved-ts
  and apply index semantics.
- latency-breakdown.md: 2 sites (async-write Apply phase, apply
  duration from RocksDB perf context).
- releases/release-7.1.6.md, release-7.5.4.md, release-7.5.5.md,
  release-7.5.6.md, release-7.5.7.md: the recurring "waiting for the
  log to be applied" TiKV-restart release note.
- releases/release-8.2.0.md: 3 sites, including 早期応募 ("early job
  application"), a homonym mistranslation of the "early apply"
  feature name, confirmed against docs-cn's 提前 apply.
- tidb-cloud/v8.5-performance-highlights.md: 1 site (leader applying
  Raft logs early).

Left untouched after verification: release-7.5.4.md's tidb_redact_log
line, release-8.2.0.md's privilege-control line,
release-8.5.8.md's flow-control, BR log-restore, and TiCDC DML-apply
lines (a different, TiCDC/BR redo-log-apply concept, not TiKV's
raftstore Apply), and several generic apply-a-formula/algorithm/
constraint sites in tikv-configuration-file.md and
performance-tuning-methods.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…shboard from this PR

Both files fully overlapped with PR pingcap#23783/pingcap#23784 (the split halves of
the 要求-to-リクエスト sweep, one of which had already fully restored
grafana-performance-overview-dashboard.md's panel names). Since this
branch was built from a pre-pingcap#23774 baseline, keeping these files here
would revert that already-merged-in-spirit work and create a same-line
merge conflict with pingcap#23783. The genuine new fixes from this PR (Raft
apply/ready jargon, and the panel-name restoration for
dashboard-monitoring.md that hadn't been done anywhere else) have been
reapplied directly onto PR pingcap#23783's branch instead, so nothing is lost
-- just moved to avoid duplicating/conflicting with already-in-flight
work.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2026
@yahonda

yahonda commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Closing per a policy reversal: decided to revert the Raft ready/apply literal-English decision entirely (see #23781's latest commit) and keep the original Japanese translations (準備完了/適用). This PR's whole purpose was that literal-English conversion, so it's now moot.

@yahonda yahonda closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant