Skip to content

i18n(ja): restore literal quoted config/log-level values across the corpus - #23759

Open
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-more-quoted-literals-japanese
Open

i18n(ja): restore literal quoted config/log-level values across the corpus#23759
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-more-quoted-literals-japanese

Conversation

@yahonda

@yahonda yahonda commented Sep 7, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Follow-up corpus-wide search for the same defect class fixed in #23758: literal English config/log-level values quoted with full-width Japanese corner brackets (「」) instead of the literal string in straight double quotes (""), matching the EN source.

  • ticdc/ticdc-manage-changefeed.md: sort_engine value "unified".
  • pd-configuration-file.md, command-line-flags-for-pd-configuration.md: name value "pd" (identical example sentence in both files).
  • sql-statements/sql-statement-restore.md: storage engine names "tikv" and "unistore".
  • ticdc/ticdc-open-api.md, ticdc/ticdc-open-api-v2.md: the 7 literal zap log-level values ("debug", "info", "warn", "error", "dpanic", "panic", "fatal").

All fixes verified against the English source on release-8.5.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Standardized quotation marks and parentheses in Japanese documentation examples and descriptions.
    • Updated formatting across PD configuration, SQL restore, TiCDC management, and TiCDC OpenAPI documentation.
    • No functional, API, or configuration behavior changes.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: cae921c6-279d-4280-8e60-2438aff02410

📥 Commits

Reviewing files that changed from the base of the PR and between 80dffad and 14a22e4.

📒 Files selected for processing (6)
  • command-line-flags-for-pd-configuration.md
  • pd-configuration-file.md
  • sql-statements/sql-statement-restore.md
  • ticdc/ticdc-manage-changefeed.md
  • ticdc/ticdc-open-api-v2.md
  • ticdc/ticdc-open-api.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The changes update punctuation in six Japanese documentation lines. They replace full-width parentheses or quotation marks with ASCII equivalents. No code, API behavior, or technical meaning changes.

Changes

Documentation typography

Layer / File(s) Summary
Normalize documentation punctuation
command-line-flags-for-pd-configuration.md, pd-configuration-file.md, sql-statements/sql-statement-restore.md, ticdc/ticdc-manage-changefeed.md, ticdc/ticdc-open-api-v2.md, ticdc/ticdc-open-api.md
Examples, storage engine names, sorter values, and log level names now use ASCII punctuation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f7dd8

This updates Japanese documentation typography for configuration values, storage engines, and log levels without changing documented behavior or product functionality. No current merge-readiness risk remains.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the documentation change: restoring literal quoted configuration and log-level values across the Japanese documentation corpus.
Description check ✅ Passed The description identifies all changed files and values, explains the formatting correction, specifies the affected Japanese 8.5 documentation branch, references the related issue, and records AI invo…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 8, 2026
…759-merge

# Conflicts:
#	sql-statements/sql-statement-restore.md
#	ticdc/ticdc-open-api-v2.md
#	ticdc/ticdc-open-api.md
@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2026
@qiancai

qiancai commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

@yahonda no file is changed in this PR. PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants