migrate-with-more-columns-downstream: fix --master-addr flag dash inconsistency - #23748
migrate-with-more-columns-downstream: fix --master-addr flag dash inconsistency#23748yahonda wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 37 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe documentation updates the Changesbinlog-schema option documentation
Priority: ⬇️ Low — Impact reflects low issue severity. Estimated code review effort: 1 (Trivial) | ~2 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The binlog-schema option reference now uses the correct --master-addr form, aligning the documentation with expected command usage. The change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review |
|
What is changed, added or deleted? (Required)
The option-reference table in
migrate-with-more-columns-downstream.mddocumented thedmctlflag as-master-addr(single dash), while every example command in the same file uses--master-addr(double dash).Verified against the dmctl flag definition in
pingcap/tiflow(dm/ctl/common/config.go):master-addris registered as apflaglong-form string flag (fs.String("master-addr", ...)), whose canonical invocation is--master-addr. A single-dash-master-addris also accepted, but only via an explicit backward-compatibility shim (argsNeedAdjustin the same file, introduced in pingcap/tiflow commit b1018964e2 "dmctl: fix dmctl command to improve its usability") that rewrites the legacy single-dash form internally — it is not the current canonical usage.This PR updates the table to
`--master-addr`to match the canonical form used throughout this file's own example commands.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
binlog-schemacommand parameter documentation to use the--master-addroption name.