sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description by yahonda · Pull Request #23196 · pingcap/docs

yahonda · 2026-07-03T05:35:44Z

What is changed, added or deleted? (Required)

Align the FLUSH PRIVILEGES description with MySQL documentation. Changed:

reload the in-memory copy of privileges from the privilege tables
reload the grant tables into memory

MySQL's own documentation at https://dev.mysql.com/doc/refman/8.4/en/privilege-changes.html uses reload the grant tables without copy. TiDB documentation should follow the same concise style.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Other reference link(s): https://dev.mysql.com/doc/refman/8.4/en/privilege-changes.html

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch

Summary by CodeRabbit

Documentation
- Clarified that FLUSH PRIVILEGES reloads grant tables into memory.

gemini-code-assist

Code Review

This pull request simplifies the description of the FLUSH PRIVILEGES statement by changing "in-memory copy of privileges" to "in-memory privileges". The reviewer suggested further simplifying the text by removing "in-memory" entirely to avoid unnecessary words, which aligns with the style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

coderabbitai · 2026-07-31T07:09:37Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

The FLUSH PRIVILEGES documentation now states that TiDB reloads grant tables into memory.

Changes

FLUSH PRIVILEGES documentation

Layer / File(s)	Summary
Update reload source wording `sql-statements/sql-statement-flush-privileges.md`, `sql-statements/sql-statement-overview.md`	Both descriptions identify grant tables as the source reloaded into memory.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type/enhancement

Suggested reviewers: ti-chi-bot

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the wording change to the FLUSH PRIVILEGES documentation.
Description check	✅ Passed	The description explains the change, affected TiDB version, and reference link; the required sections are mostly complete.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-08-10T00:56:53Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ee9165c2-e9df-4af7-82ee-c17c1c670032

📥 Commits

Reviewing files that changed from the base of the PR and between 351d30f and b1153d6.

📒 Files selected for processing (1)

sql-statements/sql-statement-flush-privileges.md

Apply CodeRabbit's review suggestion on PR pingcap#23196: describe what FLUSH PRIVILEGES actually does (reload the grant tables into memory), matching MySQL's own documentation wording, instead of the narrower 'reload the privileges from the grant tables'. Also updates sql-statement-overview.md's summary table entry, which still had the original 'in-memory copy of privileges from the privilege tables' wording and was missed when this PR first touched the main page.

CLAassistant · 2026-08-14T09:52:33Z

All committers have signed the CLA.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

qiancai

Rest LGTM

ti-chi-bot · 2026-09-03T06:02:03Z

[LGTM Timeline notifier]

Timeline:

2026-09-03 06:02:02.856016038 +0000 UTC m=+1345558.027110145: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>

ti-chi-bot · 2026-09-07T02:10:14Z

@qiancai: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qiancai · 2026-09-07T02:10:20Z

/approve

ti-chi-bot · 2026-09-07T02:10:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [qiancai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-09-07T02:19:32Z

In response to a cherrypick label: new pull request created to branch master: #23753.
But this PR has conflicts, please resolve them!

ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2026

gemini-code-assist Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread sql-statements/sql-statement-flush-privileges.md Outdated

yahonda force-pushed the fix-flush-privileges-copy branch from 1ddda69 to cfe6984 Compare July 3, 2026 05:40

yahonda force-pushed the fix-flush-privileges-copy branch from b611f65 to 4f311df Compare August 3, 2026 00:16

yahonda force-pushed the fix-flush-privileges-copy branch from 4f311df to b1153d6 Compare August 10, 2026 00:56

coderabbitai Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread sql-statements/sql-statement-flush-privileges.md Outdated

sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description

5abe346

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

yahonda force-pushed the fix-flush-privileges-copy branch from 16c7853 to 5abe346 Compare September 2, 2026 02:42

qiancai approved these changes Sep 3, 2026

View reviewed changes

Comment thread sql-statements/sql-statement-flush-privileges.md Outdated

Comment thread sql-statements/sql-statement-overview.md Outdated

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 3, 2026

qiancai self-assigned this Sep 3, 2026

qiancai added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-master Should cherry pick this PR to master branch. labels Sep 3, 2026

ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Sep 3, 2026

yahonda and others added 2 commits September 3, 2026 15:40

Update sql-statements/sql-statement-flush-privileges.md

9f3eccd

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-statements/sql-statement-overview.md

8fc3189

Co-authored-by: Grace Cai <qqzczy@126.com>

qiancai approved these changes Sep 7, 2026

View reviewed changes

qiancai added the lgtm label Sep 7, 2026

ti-chi-bot Bot added the approved label Sep 7, 2026

ti-chi-bot Bot merged commit 1a0b8b7 into pingcap:release-8.5 Sep 7, 2026
12 checks passed

ti-chi-bot mentioned this pull request Sep 7, 2026

sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description (#23196) #23753

Open

15 tasks

Uh oh!

Conversation

yahonda commented Jul 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Summary by CodeRabbit

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

coderabbitai Bot commented Aug 10, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CLAassistant commented Aug 14, 2026 • edited by pingcap-cla-assistant Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qiancai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot Bot commented Sep 3, 2026

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot Bot commented Sep 7, 2026

Uh oh!

qiancai commented Sep 7, 2026

Uh oh!

ti-chi-bot Bot commented Sep 7, 2026

Uh oh!

Uh oh!

ti-chi-bot commented Sep 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yahonda commented Jul 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 31, 2026 •

edited

Loading

CLAassistant commented Aug 14, 2026 •

edited by pingcap-cla-assistant Bot

Loading