Skip to content

sql: document unsupported GRANT PROXY in MySQL compatibility (#21924) - #21928

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-21924-to-master
Sep 10, 2026
Merged

sql: document unsupported GRANT PROXY in MySQL compatibility (#21924)#21928
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-21924-to-master

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Sep 10, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #21924

What is changed, added or deleted? (Required)

  • Add the corresponding Chinese MySQL compatibility note to sql-statements/sql-statement-grant-privileges.md to clarify that TiDB does not support GRANT PROXY.
  • This update is scoped to release-8.5 because it documents the currently published behavior verified in TiDB Cloud Starter.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • 文档更新
    • 更新 GRANT <privileges> 的 MySQL 兼容性说明。
    • 补充 TiDB 自 v8.5.6 起支持列级权限管理,可针对特定表列授予或回收 SELECTINSERTUPDATEREFERENCES 权限。
    • 说明 TiDB 不支持 MySQL 的 GRANT PROXY

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added area/security Relates to TiDB security and privilege. contribution This PR is from a community contributor. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Sep 10, 2026
@ti-chi-bot

Copy link
Copy Markdown
Member Author

@doc-claw-bot This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b5e8d59c-9b91-4a68-a062-29c38e4788d7

📥 Commits

Reviewing files that changed from the base of the PR and between 482a58c and ce7af34.

📒 Files selected for processing (1)
  • sql-statements/sql-statement-grant-privileges.md
💤 Files with no reviewable changes (1)
  • sql-statements/sql-statement-grant-privileges.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

更新 GRANT <privileges> 文档的 MySQL 兼容性章节,说明 TiDB 不支持 GRANT PROXY

Changes

GRANT 权限兼容性

Layer / File(s) Summary
更新 MySQL 兼容性说明
sql-statements/sql-statement-grant-privileges.md
新增 TiDB 不支持 GRANT PROXY 的说明。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ce7af

This update only documents that TiDB does not support GRANT PROXY and does not change product behavior; resolve the noted merge conflicts before merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了主要变更:在 MySQL 兼容性文档中说明不支持 GRANT PROXY
Description check ✅ Passed 描述包含变更内容、适用版本、相关 PR 和参考链接,并说明了 v8.5 范围及 AI 参与情况。整体符合模板要求。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0af25ec1-92d1-46ec-9966-e8cfed27fa64

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6bf64 and 482a58c.

📒 Files selected for processing (1)
  • sql-statements/sql-statement-grant-privileges.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread sql-statements/sql-statement-grant-privileges.md Outdated
Comment thread sql-statements/sql-statement-grant-privileges.md Outdated
Comment thread sql-statements/sql-statement-grant-privileges.md Outdated
@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2026
@qiancai

qiancai commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

/approve

@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 10, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 924e58f into pingcap:master Sep 10, 2026
11 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-21924-to-master branch September 10, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/security Relates to TiDB security and privilege. contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants