go.mod: bump Go 1.25.11 → 1.25.12 (fix govulncheck GO-2026-5856)#365
Open
Alexgodoroja wants to merge 1 commit into
Open
go.mod: bump Go 1.25.11 → 1.25.12 (fix govulncheck GO-2026-5856)#365Alexgodoroja wants to merge 1 commit into
Alexgodoroja wants to merge 1 commit into
Conversation
0a2145a to
d48fd14
Compare
govulncheck fails repo-wide (and on main/nightly) on GO-2026-5856, a crypto/tls vulnerability in the Go standard library, reached from telemetry/client.go, daemon.go and pilotctl/main.go. It is fixed in crypto/tls@go1.25.12 (the current latest 1.25.x). All workflows resolve their toolchain from go.mod (go-version-file: go.mod), so bumping the `go` directive clears the finding everywhere. No code changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d48fd14 to
5c25889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
govulncheckis failing repo-wide (including onmain/nightly) on GO-2026-5856, a vulnerability in the Go standard librarycrypto/tls— reached frompkg/telemetry/client.go,pkg/daemon/daemon.go, andcmd/pilotctl/main.go. It is fixed incrypto/tls@go1.25.12(the current latest 1.25.x release).What
Bump the
godirective ingo.modfrom1.25.11→1.25.12. Every workflow resolves its toolchain viago-version-file: go.mod, so this one line clears the finding across CI. No code changes.Note
This is the actual cause of the red
govulncheckon the catalogue-metadata PR (#364), which only touchescatalogue.jsonand cannot fix a stdlib CVE. Once this merges, #364 (rebased) goes green.🤖 Generated with Claude Code