feat(API): include review_due_date in job responses#1205
Merged
Sven Dunemann (forelabs) merged 2 commits intoJun 19, 2026
Conversation
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
Sven Dunemann (forelabs)
changed the title
Sven Dunemann (forelabs)
approved these changes
Jun 19, 2026
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated by the
openapi-applyagent in response to a/openapi-sync applyrequest onPhrase-Engineering/strings-app#17981.
What changed in the API
GET /api/v2/projects/{project_id}/jobs,GET /api/v2/projects/{project_id}/jobs/{id},POST,PATCH, and job action endpoints):review_due_datewas previously absent from the response when the project does not have the review workflow feature enabled. It is now always present, returningnullfor projects without the review workflow. Clients that checked for the presence of this key as a signal will observe different behavior.GET /api/v2/accounts/{account_id}/jobs: Samereview_due_datechange applies to the account-scoped job list.Source
Notes for reviewers
make lintran successfully for the swagger-cli validation step (main.yaml is valid) and the bundle step. Theopenapi-generator-cli validatestep (run vialint.sh) could not execute becausejavais not installed in the CI environment where this agent runs — this is a pre-existing infrastructure constraint, not caused by the spec changes. Theopenapi-generator-clioutput ended withNo validation errorsbefore the Java-not-found error, suggesting the validation logic did not find issues before the JVM invocation failed.review_due_datewas not previously present inschemas/job.yamlorschemas/job_details.yamlat all (not even as a conditional property), so norequiredarray changes were needed.schemas/job.yaml(base shape, used byJobSerializer) andschemas/job_details.yaml(extended shape, used byJobDetailSerializer), following the existing convention for fields likeautomation_idandjob_template_idwhich also appear in both files.review_due_dateas a proxy for detecting review workflow status. The changelog entry here should document this.JobWebhookSerializerreceived the same serializer change) are tracked inwebhook_schemas/which is synced separately fromstrings-appand is off-limits for this PR.Opened automatically by the
openapi-applyagent. Review the spec changesagainst the linked strings-app PR; the agent does not vouch for correctness
beyond "the YAML parsed and the documented layout was followed."