Infer closure parameter types in array arguments - #6422
Merged
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.3.x. PHPStan 2.3 is not going to be released for months. If your code is relevant on 2.2.x and you want it to be released sooner, please rebase your pull request and change its target to 2.2.x. |
Contributor
|
Thank you but there is one missing feature that my previous PR was handling. https://phpstan.org/r/bc3d261f-c044-45a7-bec5-b21094c41561 My PR was dumping Do you think this can be supported? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closures passed inside array arguments now inherit their parameter types from the expected array element type. For example, a closure inside an
array<Closure(string, int): mixed>parameter seesstringandintinstead ofmixed.Pass the expected PHPDoc and native types through expression context to array elements and closure analysis. This also covers arrow functions, nested arrays, array shapes, nullable arrays, and iterable parameters while preserving explicit closure parameter types.
Added the original playground reproducers for both issues and additional inference coverage. All three regression fixtures fail without the source changes and pass with them restored. The full suite passes (21,799 tests, 67 skipped), as do
make phpstanand coding style checks for the changed source files.Closes phpstan/phpstan#6430
Closes phpstan/phpstan#11215